Bug 234859

Summary: Review Request: perl-Object-Realize-Later - Delayed creation of objects
Product: [Fedora] Fedora Reporter: Tom "spot" Callaway <tcallawa>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideFlags: panemade: fedora-review+
wtogami: fedora-cvs+
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-04-09 15:39:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 234862    

Description Tom "spot" Callaway 2007-04-02 17:02:19 UTC
Spec URL: http://www.auroralinux.org/people/spot/review/perl-Object-Realize-Later.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/perl-Object-Realize-Later-0.16-1.src.rpm
Description: 
This module helps you implementing delay loading of object-data.  While
creating a stub-object, Object::Realize::Later simulates you got the
real data.

Comment 1 Parag AN(पराग) 2007-04-05 04:29:18 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
c6e124d52305c1f6c7f08aeaf6bd82d4  Object-Realize-Later-0.16.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/10isa.........ok
t/20can.........ok
t/30realize.....ok
t/40autoload....ok
t/41autoload....ok
t/50again.......ok
t/60module......ok
All tests successful.
Files=7, Tests=109,  0 wallclock secs ( 0.24 cusr +  0.07 csys =  0.31 CPU)
+ Provides: perl(Object::Realize::Later) = 0.16

APPROVED.


Comment 2 Tom "spot" Callaway 2007-04-09 14:14:06 UTC
New Package CVS Request
=======================
Package Name: perl-Object-Realize-Later
Short Description: Delayed creation of objects
Owners: tcallawa
Branches: FC-5 FC-6
InitialCC: fedora-perl-devel-list

Comment 3 Tom "spot" Callaway 2007-04-09 15:39:27 UTC
Built.