Bug 2349591
| Summary: | Review Request: rust-tree-sitter-make - Makefile grammar for tree-sitter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Davide Cavalca <davide> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | davide, package-review |
| Target Milestone: | --- | Flags: | davide:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/tree-sitter-make | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-03-04 04:35:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2333626 | ||
|
Description
Michel Lind
2025-03-03 18:41:48 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=129774389 Copr build: https://copr.fedorainfracloud.org/coprs/build/8720616 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2349591-rust-tree-sitter-make/fedora-rawhide-x86_64/08720616-rust-tree-sitter-make/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. ❯ cat rust2rpm.toml [package] cargo-toml-patch-comments = [ "include LICENSE", ] license-files = [ "LICENSE", ] [[package.extra-sources]] number = 2 file = "https://raw.githubusercontent.com/tree-sitter-grammars/%{crate}/refs/tags/v%{version}/LICENSE" comments = [ "include license file", "https://github.com/tree-sitter-grammars/tree-sitter-make/pull/5", ] [scripts.prep] post = [ """\ # copy in license file cp -p %{SOURCE2} .\ """, ] Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tree-sitter-make FEDORA-2025-28b21b3cb5 (rust-tree-sitter-make-1.1.1-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-28b21b3cb5 FEDORA-2025-28b21b3cb5 (rust-tree-sitter-make-1.1.1-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-6540e91ccc (rust-tree-sitter-make-1.1.1-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-6540e91ccc FEDORA-2025-a62d698d3d (rust-tree-sitter-make-1.1.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-a62d698d3d FEDORA-2025-236b3cc4bc (rust-tree-sitter-make-1.1.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-236b3cc4bc FEDORA-2025-a62d698d3d has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a62d698d3d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a62d698d3d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-236b3cc4bc has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-236b3cc4bc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-236b3cc4bc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-6540e91ccc has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-6540e91ccc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-6540e91ccc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-236b3cc4bc (rust-tree-sitter-make-1.1.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-6540e91ccc (rust-tree-sitter-make-1.1.1-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-a62d698d3d (rust-tree-sitter-make-1.1.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |