Bug 2349607

Summary: Review Request: rust-tree-sitter-rust - Rust grammar for tree-sitter
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/tree-sitter-rust
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-03-04 04:41:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2333626    

Description Michel Lind 2025-03-03 19:24:02 UTC
Spec URL: https://salimma.fedorapeople.org/rust-tree-sitter-rust.spec
SRPM URL: https://salimma.fedorapeople.org/rust-tree-sitter-rust-0.23.2-1.fc41.src.rpm

Description:
Rust grammar for tree-sitter.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2025-03-03 19:26:34 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=129774879

❯ cat rust2rpm.toml 
[package]
cargo-toml-patch-comments = [
  "include LICENSE",
]
license-files = [
  "LICENSE",
]

[[package.extra-sources]]
number = 2
file = "https://raw.githubusercontent.com/tree-sitter/%{crate}/refs/tags/v%{version}/LICENSE"
comments = [
  "include license file",
  "https://github.com/tree-sitter/tree-sitter-rust/pull/263",
]

[scripts.prep]
post = [
  """\
# copy in license file
cp -p %{SOURCE2} .\
""",
]

Comment 2 Fedora Review Service 2025-03-03 19:30:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8720715
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2349607-rust-tree-sitter-rust/fedora-rawhide-x86_64/08720715-rust-tree-sitter-rust/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2025-03-04 04:12:23 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fedora Admin user for bugzilla script actions 2025-03-04 04:25:05 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tree-sitter-rust

Comment 5 Fedora Update System 2025-03-04 04:39:25 UTC
FEDORA-2025-aa12cab385 (rust-tree-sitter-rust-0.23.2-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-aa12cab385

Comment 6 Fedora Update System 2025-03-04 04:41:53 UTC
FEDORA-2025-aa12cab385 (rust-tree-sitter-rust-0.23.2-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2025-03-04 05:46:10 UTC
FEDORA-2025-fddba90c5c (rust-tree-sitter-rust-0.23.2-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-fddba90c5c

Comment 8 Fedora Update System 2025-03-04 05:46:10 UTC
FEDORA-2025-e93aa443e1 (rust-tree-sitter-rust-0.23.2-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-e93aa443e1

Comment 9 Fedora Update System 2025-03-05 02:23:41 UTC
FEDORA-2025-f1002b857f has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-f1002b857f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-f1002b857f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2025-03-05 02:51:40 UTC
FEDORA-2025-e93aa443e1 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-e93aa443e1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e93aa443e1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2025-03-05 03:23:59 UTC
FEDORA-2025-fddba90c5c has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-fddba90c5c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-fddba90c5c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2025-03-13 01:10:24 UTC
FEDORA-2025-e93aa443e1 (rust-tree-sitter-rust-0.23.2-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2025-03-13 01:48:21 UTC
FEDORA-2025-fddba90c5c (rust-tree-sitter-rust-0.23.2-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2025-03-15 00:39:20 UTC
FEDORA-2025-f1002b857f (rust-tree-sitter-rust-0.23.2-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.