Bug 2349757

Summary:	Review Request: python-roman-numerals-py - Manipulate well-formed Roman numerals
Product:	[Fedora] Fedora	Reporter:	Karolina Surma <ksurma>
Component:	Package Review	Assignee:	Miro Hrončok <mhroncok>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mhroncok, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	mhroncok: fedora-review+
Hardware:	All
OS:	Linux
URL:	https://github.com/AA-Turner/roman-numerals/blob/master/CHANGES.rst
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-03-05 11:17:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Karolina Surma 2025-03-04 10:04:09 UTC

Spec URL: https://ksurma.fedorapeople.org/python-roman-numerals-py/python-roman-numerals-py.spec
SRPM URL: https://ksurma.fedorapeople.org/python-roman-numerals-py/python-roman-numerals-py-3.1.0-1.fc41.src.rpm
Description: This project provides utilities manipulating well-formed Roman numerals, in various programming languages. Needed as a runtime dependency for Sphinx 8.2.0+
Fedora Account System Username: ksurma

Comment 1 Fedora Review Service 2025-03-04 10:08:06 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8722378
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2349757-python-roman-numerals-py/fedora-rawhide-x86_64/08722378-python-roman-numerals-py/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Karolina Surma 2025-03-05 10:51:03 UTC

[fedora-review-service-build]

Comment 3 Miro Hrončok 2025-03-05 10:54:06 UTC

spec file looks sane. rpmlint-reported issues seem fixed.



Opinionated suggestion: Add -L to %pyproject_save_files (explicit is better than implicit).



(Build)Requires looking good:

$ rpm -qRp python-roman-numerals-py-3.1.0-1.fc43.src.rpm 
(python3dist(flit-core) < 4~~ with python3dist(flit-core) >= 3.7)
(python3dist(tomli) if python3-devel < 3.11)
pyproject-rpm-macros
python3-devel
python3-devel
python3dist(packaging)
python3dist(pip) >= 19
python3dist(pytest) >= 8
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(DynamicBuildRequires) <= 4.15.0-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(RichDependencies) <= 4.12.0-1
rpmlib(TildeInVersions) <= 4.10.0-1

$ rpm -qRp python3-roman-numerals-py-3.1.0-1.fc43.noarch.rpm 
python(abi) = 3.13
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1


The license tag looks good and %check passes.

APPROVED (if it still builds).

Comment 4 Miro Hrončok 2025-03-05 10:54:48 UTC

APPROVED

Comment 5 Fedora Admin user for bugzilla script actions 2025-03-05 11:03:46 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-roman-numerals-py

Comment 6 Fedora Update System 2025-03-05 11:13:57 UTC

FEDORA-2025-9f0083f3c2 (python-roman-numerals-py-3.1.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-9f0083f3c2

Comment 7 Fedora Update System 2025-03-05 11:17:56 UTC

FEDORA-2025-9f0083f3c2 (python-roman-numerals-py-3.1.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.