Bug 235039

Summary: conditionalized flush causes clear region requests to remain unflushed
Product: Red Hat Enterprise Linux 5 Reporter: Jonathan Earl Brassow <jbrassow>
Component: kernelAssignee: Jonathan Earl Brassow <jbrassow>
Status: CLOSED ERRATA QA Contact: Martin Jenner <mjenner>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.0CC: mbroz
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2007-0959 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-11-07 19:45:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jonathan Earl Brassow 2007-04-03 15:00:51 UTC
If you suspend/dtr a mirror, clear region requests are not flushed to disk. 
This means that the next time a cluster mirror is started, those regions will be
incorrectly assumed to be not in-sync.

The culprit is in rh_update_states:
        if (!list_empty(&recovered))
                rh->log->type->flush(rh->log);

The conditional should be removed.  Note that this does not cause extra disk
activity, since the (disk) log checks for lc->touched.

Comment 1 Jonathan Earl Brassow 2007-04-05 16:08:20 UTC
patch posted to dm-devel

https://www.redhat.com/archives/dm-devel/2007-April/msg00002.html


Comment 2 Jonathan Earl Brassow 2007-05-08 18:23:26 UTC
assigned -> post


Comment 3 RHEL Program Management 2007-05-08 18:42:29 UTC
This request was evaluated by Red Hat Kernel Team for inclusion in a Red
Hat Enterprise Linux maintenance release, and has moved to bugzilla 
status POST.

Comment 4 Don Zickus 2007-06-16 00:33:38 UTC
in 2.6.18-27.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 7 errata-xmlrpc 2007-11-07 19:45:55 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2007-0959.html