Bug 2351385

Summary: python-flake8-comprehensions fails to build with Python 3.14: Unnecessary reversed call around sorted() in 10 tests
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: python-flake8-comprehensionsAssignee: Scott K Logan <logans>
Status: NEW --- QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fti-bugs, ksurma, logans, mhroncok
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2322407, 2339432, 2339435    

Description Karolina Surma 2025-03-11 15:16:27 UTC
python-flake8-comprehensions fails to build with Python 3.14.0a5.

_____ test_C413_fail[reversed(sorted([2, 3, 1], reverse=False))-failures2] _____

code = 'reversed(sorted([2, 3, 1], reverse=False))'
failures = ['./example.py:1:1: C413 Unnecessary reversed call around sorted() - use sorted(..., reverse=True).']
flake8_path = Flake8Path('/tmp/pytest-of-mockbuild/pytest-0/flake8_path8')

    @pytest.mark.parametrize(
        "code,failures",
        [
            (
                "list(sorted([2, 3, 1]))",
                ["./example.py:1:1: C413 Unnecessary list call around sorted()."],
            ),
            (
                "reversed(sorted([2, 3, 1]))",
                [
                    "./example.py:1:1: C413 Unnecessary reversed call around sorted()"
                    + " - use sorted(..., reverse=True)."
                ],
            ),
            (
                "reversed(sorted([2, 3, 1], reverse=False))",
                [
                    "./example.py:1:1: C413 Unnecessary reversed call around sorted()"
                    + " - use sorted(..., reverse=True)."
                ],
            ),
            (
                "reversed(sorted([2, 3, 1], reverse=True))",
                [
                    "./example.py:1:1: C413 Unnecessary reversed call around sorted()"
                    + " - use sorted(..., reverse=False)."
                ],
            ),
            (
                "reversed(sorted([2, 3, 1], reverse=0))",
                [
                    "./example.py:1:1: C413 Unnecessary reversed call around sorted()"
                    + " - use sorted(..., reverse=True)."
                ],
            ),
            (
                "reversed(sorted([2, 3, 1], reverse=1))",
                [
                    "./example.py:1:1: C413 Unnecessary reversed call around sorted()"
                    + " - use sorted(..., reverse=False)."
                ],
            ),
            (
                "reversed(sorted([2, 3, 1], reverse=bool()))",
                [
                    "./example.py:1:1: C413 Unnecessary reversed call around sorted()"
                    + " - toggle reverse argument to sorted()."
                ],
            ),
            (
                "reversed(sorted([2, 3, 1], reverse=not True))",
                [
                    "./example.py:1:1: C413 Unnecessary reversed call around sorted()"
                    + " - toggle reverse argument to sorted()."
                ],
            ),
        ],
    )
    def test_C413_fail(code, failures, flake8_path):
        (flake8_path / "example.py").write_text(dedent(code))
        result = flake8_path.run_flake8()
>       assert result.out_lines == failures
E       AssertionError: assert [] == ['./example.p...verse=True).']
E         
E         Right contains one more item: './example.py:1:1: C413 Unnecessary reversed call around sorted() - use sorted(..., reverse=True).'
E         Use -v to get more diff

FAILED tests/test_flake8_comprehensions.py::test_C413_fail[reversed(sorted([2, 3, 1], reverse=False))-failures2]
FAILED tests/test_flake8_comprehensions.py::test_C413_fail[reversed(sorted([2, 3, 1], reverse=not True))-failures7]
FAILED tests/test_flake8_comprehensions.py::test_C413_fail[reversed(sorted([2, 3, 1], reverse=0))-failures4]
FAILED tests/test_flake8_comprehensions.py::test_C415_fail[reversed([2, 3, 1][::-1])-failures3]
FAILED tests/test_flake8_comprehensions.py::test_C413_fail[reversed(sorted([2, 3, 1], reverse=True))-failures3]
FAILED tests/test_flake8_comprehensions.py::test_C415_fail[sorted([2, 3, 1][::-1])-failures1]
FAILED tests/test_flake8_comprehensions.py::test_C413_fail[reversed(sorted([2, 3, 1], reverse=bool()))-failures6]
FAILED tests/test_flake8_comprehensions.py::test_C413_fail[reversed(sorted([2, 3, 1], reverse=1))-failures5]
FAILED tests/test_flake8_comprehensions.py::test_C415_fail[sorted([2, 3, 1][::-1], reverse=True)-failures2]
FAILED tests/test_flake8_comprehensions.py::test_C415_fail[set([2, 3, 1][::-1])-failures0]
======================= 10 failed, 111 passed in 15.08s ========================

https://docs.python.org/3.14/whatsnew/3.14.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.14/fedora-rawhide-x86_64/08739195-python-flake8-comprehensions/

For all our attempts to build python-flake8-comprehensions with Python 3.14, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.14/package/python-flake8-comprehensions/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.14:
https://copr.fedorainfracloud.org/coprs/g/python/python3.14/

Let us know here if you have any questions.

Python 3.14 is planned to be included in Fedora 43.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.14.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karolina Surma 2025-06-11 15:59:01 UTC
*** Bug 2371905 has been marked as a duplicate of this bug. ***