Bug 2352654

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8769790
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2352654-openapi-python-client/fedora-rawhide-x86_64/08769790-openapi-python-client/fedora-review/review.txt

Found issues:

- Unversionned Python dependency found.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies
- License file license.cpython-313.opt-1.pyc is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec URL: https://download.copr.fedorainfracloud.org/results/dogukancagatay/openapi-python-client/fedora-rawhide-x86_64/08771589-openapi-python-client/openapi-python-client.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/dogukancagatay/openapi-python-client/fedora-rawhide-x86_64/08771589-openapi-python-client/openapi-python-client-0.24.1-1.fc43.src.rpm

Updated to latest upstream version `0.24.1`.

Created attachment 2080395 [details]
The .spec file difference from Copr build 8769790 to 8771594

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8771594
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2352654-openapi-python-client/fedora-rawhide-x86_64/08771594-openapi-python-client/fedora-review/review.txt

Found issues:

- License file license.cpython-313.opt-1.pyc is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec URL: https://download.copr.fedorainfracloud.org/results/dogukancagatay/openapi-python-client/fedora-rawhide-x86_64/08824766-openapi-python-client/openapi-python-client.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/dogukancagatay/openapi-python-client/fedora-rawhide-x86_64/08824766-openapi-python-client/openapi-python-client-0.24.2-1.fc43.src.rpm

- Updated to latest upstream version `0.24.2`.
- Removed ExcludeArch since the package is `noarch`
- Removed `debug_package %{nil}` definition

Spec URL: https://download.copr.fedorainfracloud.org/results/dogukancagatay/openapi-python-client/fedora-rawhide-x86_64/08827583-openapi-python-client/openapi-python-client.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/dogukancagatay/openapi-python-client/fedora-rawhide-x86_64/08827583-openapi-python-client/openapi-python-client-0.24.2-1.fc43.src.rpm

- Fixed the garbled man pages
- Added `python3-hatchling` as build requirement

APPROVED, but please do fix the "man1" filename as listed below.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======

Can you rename the Source1 "man1" to "openapi-python-client.man1" ? I just
don't like the too generic name. Because if you install many source rpms,
these files end up in ~/rpmbuild/SOURCES/ and it is both not very recognisable
and could conflict with another package doing the same kind of packaging.


[this is a false positive]
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.cpython-313.opt-1.pyc is not marked as
  %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License", "*No copyright* Apache License 2.0". 420 files have unknown
     license. Detailed output of licensecheck in /tmp/2352654-openapi-
     python-client/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.13,
     /usr/lib/python3.13/site-packages
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 65660 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====


Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: openapi-python-client-0.24.2-1.fc43.noarch.rpm
          openapi-python-client-0.24.2-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmped3dgmwm')]
checks: 32, packages: 2

openapi-python-client.noarch: W: hidden-file-or-dir /usr/lib/python3.13/site-packages/openapi_python_client/templates/.gitignore.jinja
openapi-python-client.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/openapi_python_client/templates/property_templates/int_property.py.jinja /usr/lib/python3.13/site-packages/openapi_python_client/templates/property_templates/float_property.py.jinja
 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 16 filtered, 0 badness; has taken 0.7 s




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

openapi-python-client.noarch: W: hidden-file-or-dir /usr/lib/python3.13/site-packages/openapi_python_client/templates/.gitignore.jinja
openapi-python-client.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/openapi_python_client/templates/property_templates/int_property.py.jinja /usr/lib/python3.13/site-packages/openapi_python_client/templates/property_templates/float_property.py.jinja
 1 packages and 0 specfiles checked; 0 errors, 2 warnings, 12 filtered, 0 badness; has taken 0.2 s



Source checksums
----------------
https://github.com/openapi-generators/openapi-python-client/archive/refs/tags/v0.24.2/openapi-python-client-0.24.2.tar.gz :
  CHECKSUM(SHA256) this package     : d2b1eee4e8b5a61107531832620449df57a2c3a97fa4ad221b7c5fe9bb03c721
  CHECKSUM(SHA256) upstream package : d2b1eee4e8b5a61107531832620449df57a2c3a97fa4ad221b7c5fe9bb03c721


Requires
--------
openapi-python-client (rpmlib, GLIBC filtered):
    (python3.13dist(httpx) < 0.29~~ with python3.13dist(httpx) >= 0.20)
    (python3.13dist(jinja2) < 4~~ with python3.13dist(jinja2) >= 3)
    (python3.13dist(pydantic) < 3~~ with python3.13dist(pydantic) >= 2.10)
    (python3.13dist(python-dateutil) < 3~~ with python3.13dist(python-dateutil) >= 2.8.1)
    (python3.13dist(ruamel-yaml) < 0.19~~ with python3.13dist(ruamel-yaml) >= 0.18.6)
    (python3.13dist(ruff) < 0.12~~ with python3.13dist(ruff) >= 0.2)
    (python3.13dist(shellingham) < 2~~ with python3.13dist(shellingham) >= 1.3.2)
    (python3.13dist(typer) < 0.16~~ with python3.13dist(typer) > 0.6.0)
    (python3.13dist(typing-extensions) < 5~~ with python3.13dist(typing-extensions) >= 4.8)
    /usr/bin/python3
    python(abi)
    python3.13dist(attrs)



Provides
--------
openapi-python-client:
    openapi-python-client
    python3.13dist(openapi-python-client)
    python3dist(openapi-python-client)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2352654
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Python, Generic
Disabled plugins: C/C++, Perl, fonts, Ocaml, PHP, Java, R, SugarActivity, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

The Pagure repository was created at https://src.fedoraproject.org/rpms/openapi-python-client

FEDORA-2025-ce464ac596 (openapi-python-client-0.24.2-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-ce464ac596

FEDORA-2025-ce464ac596 (openapi-python-client-0.24.2-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.