Bug 2353412
| Summary: | Review Request: libgenht - Simple generic hash table implementation in C | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve <skrochen> | ||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | fedora, package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | http://repo.hu/projects/genht | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2353363 | ||||||
| Attachments: |
|
||||||
|
Description
Steve
2025-03-19 18:35:33 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8794946 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353412-libgenht/fedora-rawhide-x86_64/08794946-libgenht/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/libgenht Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > Patch0: 00-fix-makefile.patch > [...] > sed -i 's|$< $(CFLAGS)|$< $(CFLAGS) -Wno-incompatible-pointer-types|' src/Makefile You're already patching the Makefile, why use sed? Why not add this change to the patch? > %build > %set_build_flags Calling %set_build_flags manually is not needed since Fedora 36. Also, looking at the build log: > cp `pwd`/hash.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/hash.h > cp `pwd`/siphash24.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/siphash24.h > cp `pwd`/ht.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/ht.h > cp `pwd`/ht.c /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/ht.c It might be good to patch the Makefile (or alter the make call) to use "cp -p" in order to preserve file timestamps. Spec URL: https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-rawhide-x86_64/08819141-libgenht/libgenht.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/s-kro/libgenht/fedora-rawhide-x86_64/08819141-libgenht/libgenht-1.1.3-5.fc43.src.rpm Created attachment 2081959 [details]
The .spec file difference from Copr build 8794946 to 8819222
Copr build: https://copr.fedorainfracloud.org/coprs/build/8819222 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353412-libgenht/fedora-rawhide-x86_64/08819222-libgenht/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/libgenht Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Artur, thanks for the feedback >> Patch0: 00-fix-makefile.patch >> [...] >> sed -i 's|$< $(CFLAGS)|$< $(CFLAGS) -Wno-incompatible-pointer-types|' src/Makefile >you're already patching the Makefile, why use sed? >Why not add this change to the patch? The patch isn't mine, it comes from my upstream, who is a Debian Dude :) >> %build >> %set_build_flags >Calling %set_build_flags manually is not needed since Fedora 36. Done >Also, looking at the build log: >> cp `pwd`/hash.h /builddir/build/BUILD/libgenht-1.1.3-build/BUILDROOT/usr/include/genht/hash.h >>[...] >It might be good to patch the Makefile (or alter the make call) to use "cp -p" in order to preserve file timestamps. Done, also in the spec file |