Bug 2354083

Summary: hddfancontrol FTBFS due to missing tox configuration
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: hddfancontrolAssignee: Filipe Rosset <rosset.filipe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: rosset.filipe
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hddfancontrol-1.6.2-8.fc43 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-04-18 19:45:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2322407, 2339432    

Description Miro Hrončok 2025-03-21 16:29:47 UTC 
Hello.

hddfancontrol fails to build from source becasue it uses one or both of:

 - %pyproject_buildrequires -t/-e (generate dependencies via tox)
 - %tox (run tox)

without tox configuration (e.g. tox.ini or tox section of pyproject.toml/setup.cfg).

This was always supposed to fail, but regressed with tox 4.
Now it fails again.

https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/thread/ZSHSHZKVA4XJQBJD7FMMCALKN4UP5SAJ/
https://lists.fedoraproject.org/archives/list/devel-announce@lists.fedoraproject.org/thread/N25A2BER3RUHMTBIULQ6AVWRILSL5VGW/

If this package uses tox upstream, make sure to use a source tarball that includes the tox configuration (e.g. an archive from GitHub instead of sdist from PyPI).

If this package does not use tox upstream, you cannot use the tox options.
If your package uses %pyproject_buildrequires -t/-e but does not use %tox, just drop the -t/-e option.
If your package uses %tox, replace the call with a more suitable way for running tests (e.g. %pytest).

Let me know if you need assistance. Thanks.
Comment 1 Miro Hrončok 2025-03-28 12:42:04 UTC 
Hello. If you need help fixing this, please let me know. If you plan to fix this yourself, please respond. Thanks.
Comment 2 Filipe Rosset 2025-03-28 14:18:55 UTC 
(In reply to Miro Hrončok from comment #1)
> Hello. If you need help fixing this, please let me know. If you plan to fix
> this yourself, please respond. Thanks.

hi Miro,

Unfortunately I'm very busy for the next couple weeks, even on weekends, so during this timefrime I wont be able to handle Fedora stuff.
If you have bandwith please go ahead and apply the fixes neeed.
I really appreciate your work on all Python related stuff.

Thanks!
Comment 3 Miro Hrončok 2025-03-28 14:37:51 UTC 
https://src.fedoraproject.org/rpms/hddfancontrol/pull-request/2
Comment 4 Fedora Update System 2025-04-18 09:43:12 UTC 
FEDORA-2025-7fa8e1b51e (hddfancontrol-1.6.2-8.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-7fa8e1b51e
Comment 5 Fedora Update System 2025-04-18 19:45:57 UTC 
FEDORA-2025-7fa8e1b51e (hddfancontrol-1.6.2-8.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.