Bug 2354096

Summary:	python-cmd2 FTBFS due to missing tox configuration
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	python-cmd2	Assignee:	Fedora Infrastructure SIG <infra-sig>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	apevec, infra-sig, jcapitao, kevin, ktdreyer, mail, openstack-sig
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-cmd2-2.5.11-1.fc43	Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-03-29 18:09:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2322407, 2339432

Description Miro Hrončok 2025-03-21 16:31:44 UTC

Hello.

python-cmd2 fails to build from source becasue it uses one or both of:

 - %pyproject_buildrequires -t/-e (generate dependencies via tox)
 - %tox (run tox)

without tox configuration (e.g. tox.ini or tox section of pyproject.toml/setup.cfg).

This was always supposed to fail, but regressed with tox 4.
Now it fails again.

https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/thread/ZSHSHZKVA4XJQBJD7FMMCALKN4UP5SAJ/
https://lists.fedoraproject.org/archives/list/devel-announce@lists.fedoraproject.org/thread/N25A2BER3RUHMTBIULQ6AVWRILSL5VGW/

If this package uses tox upstream, make sure to use a source tarball that includes the tox configuration (e.g. an archive from GitHub instead of sdist from PyPI).

If this package does not use tox upstream, you cannot use the tox options.
If your package uses %pyproject_buildrequires -t/-e but does not use %tox, just drop the -t/-e option.
If your package uses %tox, replace the call with a more suitable way for running tests (e.g. %pytest).

Let me know if you need assistance. Thanks.

Comment 1 Miro Hrončok 2025-03-28 12:42:04 UTC

Hello. If you need help fixing this, please let me know. If you plan to fix this yourself, please respond. Thanks.

Comment 2 Kevin Fenzi 2025-03-29 18:00:25 UTC

I just pushed https://src.fedoraproject.org/rpms/python-cmd2/c/17f34caa7fc939e57b69bbaf567c5dbe17fa9bf4?branch=rawhide
which disables the coverage options to pytest and get's it mostly working. 

However, there's still 2 tests that fail. I disabled those for now, but we should figure out whats going on with them and get them re-enabled.
Help with those would be welcome!

Comment 3 Fedora Update System 2025-03-29 18:06:08 UTC

FEDORA-2025-2d19860879 (python-cmd2-2.5.11-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-2d19860879

Comment 4 Miro Hrončok 2025-03-29 18:09:04 UTC

(In reply to Kevin Fenzi from comment #2)
> However, there's still 2 tests that fail. I disabled those for now, but we
> should figure out whats going on with them and get them re-enabled.
> Help with those would be welcome!

https://src.fedoraproject.org/rpms/python-cmd2/pull-request/5

Comment 5 Fedora Update System 2025-03-29 18:09:56 UTC

FEDORA-2025-2d19860879 (python-cmd2-2.5.11-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Kevin Fenzi 2025-03-29 18:12:43 UTC

Ha. So fast... yes, that makes sense... 

Thank you!