Bug 2354139

Summary:	rpm-spec-language-server FTBFS due to missing tox configuration
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	rpm-spec-language-server	Assignee:	Jakub Kadlčík <jkadlcik>
Status:	CLOSED ERRATA	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jkadlcik
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rpm-spec-language-server-0.0.1-5.fc43 rpm-spec-language-server-0.0.1-5.fc40 rpm-spec-language-server-0.0.1-5.fc41 rpm-spec-language-server-0.0.1-5.fc42	Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-03-28 12:58:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2322407, 2339432

Description Miro Hrončok 2025-03-21 16:34:47 UTC

Hello.

rpm-spec-language-server fails to build from source becasue it uses one or both of:

 - %pyproject_buildrequires -t/-e (generate dependencies via tox)
 - %tox (run tox)

without tox configuration (e.g. tox.ini or tox section of pyproject.toml/setup.cfg).

This was always supposed to fail, but regressed with tox 4.
Now it fails again.

https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/thread/ZSHSHZKVA4XJQBJD7FMMCALKN4UP5SAJ/
https://lists.fedoraproject.org/archives/list/devel-announce@lists.fedoraproject.org/thread/N25A2BER3RUHMTBIULQ6AVWRILSL5VGW/

If this package uses tox upstream, make sure to use a source tarball that includes the tox configuration (e.g. an archive from GitHub instead of sdist from PyPI).

If this package does not use tox upstream, you cannot use the tox options.
If your package uses %pyproject_buildrequires -t/-e but does not use %tox, just drop the -t/-e option.
If your package uses %tox, replace the call with a more suitable way for running tests (e.g. %pytest).

Let me know if you need assistance. Thanks.

Comment 1 Miro Hrončok 2025-03-21 16:36:08 UTC

I seem to have opened a PR for this ~2 months ago: https://src.fedoraproject.org/rpms/rpm-spec-language-server/pull-request/1

Comment 2 Miro Hrončok 2025-03-28 12:42:04 UTC

Hello. If you need help fixing this, please let me know. If you plan to fix this yourself, please respond. Thanks.

Comment 3 Fedora Update System 2025-03-28 13:04:18 UTC

FEDORA-2025-53ebcb3bd9 (rpm-spec-language-server-0.0.1-5.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-53ebcb3bd9

Comment 4 Fedora Update System 2025-03-28 13:04:19 UTC

FEDORA-2025-43d43d25cd (rpm-spec-language-server-0.0.1-5.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-43d43d25cd

Comment 5 Jakub Kadlčík 2025-03-28 13:08:19 UTC

Sorry Miro, I somehow missed your PR. Merged and updates submitted now.

Comment 6 Fedora Update System 2025-03-29 01:31:30 UTC

FEDORA-2025-43d43d25cd has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-43d43d25cd`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-43d43d25cd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2025-03-29 02:37:41 UTC

FEDORA-2025-53ebcb3bd9 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-53ebcb3bd9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-53ebcb3bd9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2025-03-29 02:42:55 UTC

FEDORA-2025-32085b61da has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-32085b61da`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-32085b61da

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2025-04-06 01:15:36 UTC

FEDORA-2025-32085b61da (rpm-spec-language-server-0.0.1-5.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2025-04-06 01:20:45 UTC

FEDORA-2025-53ebcb3bd9 (rpm-spec-language-server-0.0.1-5.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2025-04-11 18:22:21 UTC

FEDORA-2025-43d43d25cd (rpm-spec-language-server-0.0.1-5.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.