Bug 2354327

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8806179
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2354327-python-ua-parser-builtins/fedora-rawhide-x86_64/08806179-python-ua-parser-builtins/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* Apache License 2.0", "Unknown or generated",
     "*No copyright* Apache License", "Apache License 2.0". 28 files have
     unknown license. Detailed output of licensecheck in
     /home/fedora-packaging/reviews/python-ua-parser-
     builtins/2354327-python-ua-parser-builtins/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.13/site-
     packages, /usr/lib/python3.13
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 339 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[!]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-ua-parser-builtins-0.18.0.post1-1.fc43.noarch.rpm
          python-ua-parser-builtins-0.18.0.post1-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp76s077kq')]
checks: 32, packages: 2

python-ua-parser-builtins.src: E: spelling-error ('Precompiled', 'Summary(en_US) Precompiled -> Recompiled, P recompiled, Recompile')
python-ua-parser-builtins.src: E: spelling-error ('Precompiled', '%description -l en_US Precompiled -> Recompiled, P recompiled, Recompile')
python3-ua-parser-builtins.noarch: E: spelling-error ('Precompiled', 'Summary(en_US) Precompiled -> Recompiled, P recompiled, Recompile')
python3-ua-parser-builtins.noarch: E: spelling-error ('Precompiled', '%description -l en_US Precompiled -> Recompiled, P recompiled, Recompile')
python-ua-parser-builtins.spec: W: invalid-url Source0: ua_parser_builtins-0.18.0.post1.tar.gz
 2 packages and 0 specfiles checked; 4 errors, 1 warnings, 7 filtered, 4 badness; has taken 0.7 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-ua-parser-builtins.noarch: E: spelling-error ('Precompiled', 'Summary(en_US) Precompiled -> Recompiled, P recompiled, Recompile')
python3-ua-parser-builtins.noarch: E: spelling-error ('Precompiled', '%description -l en_US Precompiled -> Recompiled, P recompiled, Recompile')
 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 3 filtered, 2 badness; has taken 0.1 s 



Requires
--------
python3-ua-parser-builtins (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python3-ua-parser-builtins:
    python-ua-parser-builtins
    python3-ua-parser-builtins
    python3.13-ua-parser-builtins
    python3.13dist(ua-parser-builtins)
    python3dist(ua-parser-builtins)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2354327
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Python, Generic
Disabled plugins: Haskell, fonts, Perl, SugarActivity, R, Ocaml, C/C++, PHP, Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Please change
Source0:        ua_parser_builtins-%{version}.tar.gz
to
Source:         %{url}/archive/%{version}/uap-python-%{version}.tar.gz
b) Please update to latest version tag 1.0.1

See https://pypi.org/project/ua-parser-builtins/

The version of ua_parser_builtins, which is split from ua_parser, is 0.18.0.post1. I've asked upstream to publish a proper sdist archive: https://github.com/ua-parser/uap-python/issues/262

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* Apache License 2.0", "Unknown or generated",
     "*No copyright* Apache License", "Apache License 2.0". 28 files have
     unknown license. Detailed output of licensecheck in
     /home/fedora-packaging/reviews/python-ua-parser-builtins/2354327-
     python-ua-parser-builtins/review-python-ua-parser-builtins/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.13,
     /usr/lib/python3.13/site-packages
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 339 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python3-ua-parser-builtins-0.18.0.post1-1.fc43.noarch.rpm
          python-ua-parser-builtins-0.18.0.post1-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp7c4sehm3')]
checks: 32, packages: 2

python-ua-parser-builtins.src: E: spelling-error ('Precompiled', 'Summary(en_US) Precompiled -> Recompiled, P recompiled, Recompile'
)
python-ua-parser-builtins.src: E: spelling-error ('Precompiled', '%description -l en_US Precompiled -> Recompiled, P recompiled, Rec
ompile')
python3-ua-parser-builtins.noarch: E: spelling-error ('Precompiled', 'Summary(en_US) Precompiled -> Recompiled, P recompiled, Recomp
ile')
python3-ua-parser-builtins.noarch: E: spelling-error ('Precompiled', '%description -l en_US Precompiled -> Recompiled, P recompiled,
 Recompile')
python-ua-parser-builtins.spec: W: invalid-url Source0: ua_parser_builtins-0.18.0.post1.tar.gz
 2 packages and 0 specfiles checked; 4 errors, 1 warnings, 7 filtered, 4 badness; has taken 0.6 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-ua-parser-builtins.noarch: E: spelling-error ('Precompiled', 'Summary(en_US) Precompiled -> Recompiled, P recompiled, Recomp
ile')
python3-ua-parser-builtins.noarch: E: spelling-error ('Precompiled', '%description -l en_US Precompiled -> Recompiled, P recompiled,
 Recompile')
 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 3 filtered, 2 badness; has taken 0.1 s 





Requires
--------
python3-ua-parser-builtins (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python3-ua-parser-builtins:
    python-ua-parser-builtins
    python3-ua-parser-builtins
    python3.13-ua-parser-builtins
    python3.13dist(ua-parser-builtins)
    python3dist(ua-parser-builtins)





Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -n python-ua-parser-builtins
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Shell-api, Generic
Disabled plugins: Haskell, fonts, PHP, R, Java, Ocaml, Perl, C/C++, SugarActivity
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Would be helpful to indicate that $pyproject_check_import cannot be run because of circular dependency on ua-parser
b) Modifying
# git clone --recursive https://github.com/ua-parser/uap-python.git ua_parser
# cd ua_parser/ua-parser-builtins
# python3 -m build --sdist
# cp dist/ua_parser_builtins-%%{version}.tar.gz ../../
to
# git clone --recursive https://github.com/ua-parser/uap-python.git ua_parser
# cd ua_parser/ua-parser-builtins
# cp ../LICENSE .
# python3 -m build --sdist
# cp dist/ua_parser_builtins-%%{version}.tar.gz ../../
and
%pyproject_save_files ua_parser_builtins
to
%pyproject_save_files -l ua_parser_builtins

allows the license to be included in the installed package.
c) Consider using %autorelease and %autochangelog macros
d) Above do not block the review, but suggestions. So Approved.
e) Review of:
https://bugzilla.redhat.com/show_bug.cgi?id=2354265
would be appreciated.

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ua-parser-builtins

Thanks for the review!

> # Nothing to test

Not even %pyproject_check_import ?

I see the comment in https://src.fedoraproject.org/rpms/python-ua-parser-builtins/c/52286ef751b7510e80b74c3579212676afdaf86d?branch=rawhide -- ignore my previous question.