Bug 2354379
| Summary: | Review Request: OpenTimelineIO - Editorial timeline information API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Cossette <farchord> | ||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | ngompa13:
fedora-review+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://github.com/AcademySoftwareFoundation/OpenTimelineIO | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | OpenTimelineIO-0.17.0-1.fc43 | Doc Type: | --- | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-03-27 11:27:52 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Steve Cossette
2025-03-24 00:17:25 UTC
Taking this review. Spec URL: https://farchord.fedorapeople.org/reviews/OpenTimelineIO/OpenTimelineIO.spec SRPM URL: https://farchord.fedorapeople.org/reviews/OpenTimelineIO/OpenTimelineIO-0.17.0-1.fc43.src.rpm Changed the license to something more accurate (Including rapidjson into it) Spec review notes: > Requires: %{name} = %{version}-%{release} This needs "%{name}%{?_isa}" > %package python The python bindings need to be named "python3-%{name}", so it needs to use "-n python3-%{name}" instead of "python". > %{_bindir}/otio* This is currently in the disabled part under the python bindings subpackage, but this needs to be split out into a tools subpackage similar to how the other O*IO packages in Fedora do it. Copr build: https://copr.fedorainfracloud.org/coprs/build/8811850 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2354379-opentimelineio/fedora-rawhide-x86_64/08811850-OpenTimelineIO/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/8811849 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2354379-opentimelineio/fedora-rawhide-x86_64/08811849-OpenTimelineIO/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://farchord.fedorapeople.org/reviews/OpenTimelineIO/OpenTimelineIO.spec SRPM URL: https://farchord.fedorapeople.org/reviews/OpenTimelineIO/OpenTimelineIO-0.17.0-1.fc43.src.rpm Implemented Reviewer's instructions Created attachment 2081647 [details]
The .spec file difference from Copr build 8811850 to 8812469
Copr build: https://copr.fedorainfracloud.org/coprs/build/8812469 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2354379-opentimelineio/fedora-rawhide-x86_64/08812469-OpenTimelineIO/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. You forgot to remove "%{_bindir}/otio*" from the file list for the python bindings.
Spec URL: https://farchord.fedorapeople.org/reviews/OpenTimelineIO/OpenTimelineIO.spec SRPM URL: https://farchord.fedorapeople.org/reviews/OpenTimelineIO/OpenTimelineIO-0.17.0-1.fc43.src.rpm Fixed mistake Review notes: * Package follows Fedora packaging guidelines * Package builds and installs * Package licensing is correct * No serious issues from rpmlint PACKAGE APPROVED. Thank you for the review, Neal The Pagure repository was created at https://src.fedoraproject.org/rpms/OpenTimelineIO FEDORA-2025-ce46949fe1 (OpenTimelineIO-0.17.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-ce46949fe1 FEDORA-2025-ce46949fe1 (OpenTimelineIO-0.17.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. |