Bug 235637
| Summary: | Review Request: smstools - Send and receive short messages through GSM modems | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andreas Thienemann <andreas> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | ville.skytta:
fedora-review-
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-13 18:44:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Andreas Thienemann
2007-04-08 18:39:20 UTC
Initial review, full one later (+ assignment to myself, in the meanwhile, others feel free to chime in) if I can get this to work with hardware I have around: (In reply to comment #0) > These errors should be ignored as the access restrictions are used to prevent > unauthorized access to the spool-dirs. * Um, "conffile-without-noreplace-flag /etc/logrotate.d/smstools" doesn't quite fall into this category, should be fixed. * Build fails if _smp_mflags is unset, a fix is not to use the toplevel Makefile but to do explicit "make -C src ..." * Init script (and logrotate file) would be better called "smsd", as that's what it starts. * Init script exit code on usage error is not LSB compliant, should be 2. See /usr/share/rpmdevtools/template.init for other related cleanup and action alias suggestions. * smsd.conf contains very environment and hardware dependent settings, perhaps it would be a better idea to ship a very dummy one containing just a comment or two about where to find examples and further info, and preferably make the service startup fail with a descriptive message (see eg. the vdr package). The currently installed one is not an appropriate default IMO, two GSM modems hardcoded to specific serial ports with hardcoded init AT commands etc. * Many docs and examples (and even the default config) contain hardcoded /usr/local paths, should be fixed to reflect actual installed locations. * Would be better to run as a dedicated low privileged user than root, doesn't look like that would be hard to implement. Device permissions would be the hardest part, IMO a quick doc about setting them for the devices in use would be good enough. * file /usr/bin/sendsms from install of smstools-3.0.6-1 conflicts with file from package gnokii-0.6.14-2.fc6 * On startup: Starting smsd: /usr/sbin/smsd: invalid option -- b * Init script's $OPTIONS value, possibly other configurable definitions should be moved to a /etc/sysconfig/smsd snippet * /usr/bin/sendsms tries to write to /var/spool/sms/outgoing which doesn't work as a normal user due to dir permissions * There are user/group smsd.conf parameters that cause dropping of privileges to those, but appears the privs are dropped before opening the device so it's not that useful (just reading the code, untested) Turns out I can only send messages with hardware at hand, receiving is not supported with it. Assigning to myself anyway. ping? ping #2? Been busy with the bacula stuff and the rest. I'll see what I can do about this here in august. Ping #3? Invoking stalled review process, and retracting from reviewer due to no real response in ~7 months. https://fedoraproject.org/wiki/Extras/Policy/StalledReviews If this is to be resurrected, coordination with another smstools review in bug 374771 is needed. |