Bug 235741
Summary: | Review Request: hippo-canvas - Crossplatform canvas using cairo | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Colin Walters <walters> | ||||
Component: | Package Review | Assignee: | Brian Pepple <bdpepple> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | bnocera, johnp, mpg, mtasaka, sebastian, tomeu | ||||
Target Milestone: | --- | Flags: | mclasen:
fedora-review+
kevin: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-06-04 22:02:06 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Colin Walters
2007-04-09 21:07:09 UTC
The spec file looks fine in general, just a few minor comments: A full source url is generally preferred, if you have one. I wondered about the fact that the -devel package does not install a .pc file. Created attachment 153716 [details]
mock build log of hippo-canvas-0.2.13-2 on FC-devel i386
Mock build on FC-devel i386 failed as attached.
rpmlint output: E: hippo-canvas zero-length /usr/share/doc/hippo-canvas-0.2.13/AUTHORS E: hippo-canvas zero-length /usr/share/doc/hippo-canvas-0.2.13/README W: hippo-canvas-devel no-documentation W: hippo-canvas-python no-documentation Package name: ok Spec file name: ok Packaging guidelines: ok, just some cosmetic things: - Descriptions should be full sentences ending in a .. - Typo: "multipul" should be "multiple" License: ok, I assume. But I wonder why you need any of the "mugshot trademark" stuff in this package. Wouldn't it be easier to just make this straight GPL, since there is no actual "Mugshot" in this package, it is just a canvas... License file included: ok Spec file language and clarity: excellent Upstream source: ok Package build: Missing BRs: pygtk2-devel, pycairo-devel Relocatable: n/a Directory ownership: ok File lists: ok %clean section: ok Macro use: ok Content: ok Large docs: n/a %doc files: AUTHORS and README are empty, so either remove them or (better) put something in them. Headers: ok pc file: n/a shared libs: ok static libs: n/a -devel dependencies: ok .la file: ok .desktop files: n/a %install section cleans buildroot: ok filename encoding: ok Thanks for the comments, I've fixed most of these issues I believe, with the exception of the doc warnings for hippo-canvas-{devel,python}; just talked with Havoc about the LICENSE and we're going to make it plain LGPL I think. A new version should be uploaded now. Yes, looks fine. Approved. I guess you need a sponsor now to get the package actually built. Of the desktop team, I know that at least alex is a sponsor, so you may want to ask him for sponsorship. Colin, I'm willing to be your sponsor. MD5Sums: 966b23b717fad5c6d3efaac199b64b93 hippo-canvas-0.2.17.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * No deprecated fields used * All necessary BuildRequires listed. * All desired features are enabled * Package rebuilds as non-root user * rpmlint only produces the following warnings that are fine: W: hippo-canvas-devel no-documentation W: hippo-canvas-python no-documentation +1 APPROVED & I'll sponsor you if no one else has yet. http://fedoraproject.org/wiki/PackageMaintainers/Join#head-0dbf12f9c493a3f20fae545bb9c1396cb0a88053 Awesome Brian, thanks for the review. As I understand the process the next step is to make an account, which I have done. My username is 'walters'. Colin, I've approved you for the cvsextras group, which should leave your at step 6 of here: http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a89568deafa65f505b4b58ee869b If you run into any problems, drop me a line. New Package CVS Request ======================= Package Name: hippo-canvas Short Description: Crossplatform canvas using cairo Owners: walters Branches: InitialCC: Colin, has this been built yet? If so, this bug can be closed. Package Change Request ====================== Package Name: hippo-canvas New Branches: F7 CVS done. Package Change Request ====================== Package Name: hippo-canvas New Owners: walters,johnp,mpg cvs done. Package Change Request ====================== Package Name: hippo-canvas New Branches: OLPC-2 cvs done. Package Change Request ====================== Package Name: hippo-canvas New Branches: OLPC-4 Owners: mpg erikos tomeu We need to fork this package because Sugar 0.83 (which should ship in the F10-based 9.1 OLPC release) depends on the three commits referenced below, which introduces API changes and thus cannot be applied in the F10 branch. http://svn.gnome.org/viewvc/hippo-canvas?view=revision&revision=7297 http://svn.gnome.org/viewvc/hippo-canvas?view=revision&revision=7296 http://svn.gnome.org/viewvc/hippo-canvas?view=revision&revision=7295 cvs done. Package Change Request ====================== Package Name: hippo-canvas New Branches: EL-6 Owners: sdz pbrobinson I'm the new owner of hippo-canvas after talking to Colin. This package is another dependency for Sugar in our effort to bring it to EPEL. CVS done (by process-cvs-requests.py). |