Bug 2357708

Summary:	Review Request: python-slip10 - Reference implementation of SLIP-0039: Shamir’s Secret-Sharing for Mnemonic Codes
Product:	[Fedora] Fedora	Reporter:	Jonny Heggheim <hegjon>
Component:	Package Review	Assignee:	Jonathan S. <js-fedora>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	js-fedora, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	js-fedora: fedora-review+
Hardware:	Unspecified
OS:	Unspecified
URL:	https://github.com/trezor/python-slip10
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-04-11 07:54:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2357689

Description Jonny Heggheim 2025-04-06 18:35:19 UTC

Spec URL: https://jonny.fedorapeople.org/python-slip10.spec
SRPM URL: https://jonny.fedorapeople.org/python-slip10-1.0.1-1.fc41.src.rpm

Description:
A reference implementation of the SLIP-0010 specification,
which generalizes the BIP-0032 derivation scheme for
private and public key pairs in hierarchical deterministic wallets
for the curves secp256k1, NIST P-256, ed25519 and curve25519.

Fedora Account System Username: jonny

Comment 1 Jonny Heggheim 2025-04-06 18:35:22 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=131196566

Comment 2 Fedora Review Service 2025-04-06 18:39:15 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8865250
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2357708-python-slip10/fedora-rawhide-x86_64/08865250-python-slip10/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Jonathan S. 2025-04-06 22:39:06 UTC

LGTM. Nit: You might want to use %autochangelog

Comment 4 Jonny Heggheim 2025-04-07 05:01:36 UTC

Thanks for the review.

I tried %autochangelog for some of my packages, but I find it clumpsy when downloading sources from upstream.

Is there an alternative for:

spectool -g file.spec

and for me there are few manual edits when using rpmdev-bumpspec and fedpkg commit -c

Comment 5 Jonny Heggheim 2025-04-07 05:03:20 UTC

I have always used used %autorelease in combination with %autochangelog

Comment 6 Fedora Admin user for bugzilla script actions 2025-04-07 05:04:41 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-slip10

Comment 7 Jonny Heggheim 2025-04-11 07:54:40 UTC

Added to Fedora 40 and later