Bug 2357906 (rust-uguid)

Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

fedora-review-service-build

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8867903
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2357906-rust-uguid/fedora-rawhide-x86_64/08867903-rust-uguid/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

There's a version 2.2.1 out now, please update.

> BuildRequires:  crate(bytemuck/default)
> BuildRequires:  crate(bytemuck/derive)

These should be necessary, even even then, it would be wrong to depend on crates without specifying which *version* you need. Which is why listing BuildRequires for Rust crates manually like this is a MUST NOT. :)

https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_dynamically_generated_buildrequires_for_crate_dependencies

Did you add this to be able to compile / run all tests without errors?

In that case, you can add `-f bytemuck` (or possibly even `-f bytemuck,serde` to the `%cargo_generate_buildrequires`, `%cargo_build`, `%cargo_install`, and `%cargo_test` macros, which should have the desired effect.

You can cause rust2rpm to do this for you permanently with this rust2rpm.toml config file:

```
[features]
enable = [
    "bytemuck",
    "serde",
]
```

Additionally, when updating the spec file for these changes, use rpmautospec. It should be the default for all new Fedora packages. Not using it for Rust packages causes a lot of manual work on crate updates (preserving %changelog entries after re-running rust2rpm, etc.).

(In reply to Fabio Valentini from comment #5)
> There's a version 2.2.1 out now, please update.

> > BuildRequires:  crate(bytemuck/default)
> > BuildRequires:  crate(bytemuck/derive)

> Did you add this to be able to compile / run all tests without errors?

Tests failed due to tests for unstable compiler features
being run and not working on the stable compiler.

That problem seems to be fixed in 2.2.1

spec url: https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/08874518-rust-uguid/rust-uguid.spec
srpm url: https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/08874518-rust-uguid/rust-uguid-2.2.1-1.fc43.src.rpm

Created attachment 2083896 [details]
The .spec file difference from Copr build 8867903 to 8874604

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8874604
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2357906-rust-uguid/fedora-rawhide-x86_64/08874604-rust-uguid/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> Tests failed due to tests for unstable compiler features
> being run and not working on the stable compiler.

I'm sorry, I'm not sure I understand. The tests *were* enabled in the spec file I reviewed?

(In reply to Fabio Valentini from comment #10)
> > Tests failed due to tests for unstable compiler features
> > being run and not working on the stable compiler.
> 
> I'm sorry, I'm not sure I understand. The tests *were* enabled in the spec
> file I reviewed?

I had used this rust2rpm.toml ...

   [requires]
   build = ["crate(bytemuck/default)", "crate(bytemuck/derive)"]

... which resulted in those dependencies beind added but also
turned off the 'unstable_tests' feature as side effect.

Have switched to use a [features] section instead in latest builds.

> I had used this rust2rpm.toml ...
> ... which resulted in those dependencies beind added but also
> turned off the 'unstable_tests' feature as side effect.

No, something else must have been going on -
because cargo simply does not support "if this dependency is available then enable this feature" type of things.
Feature flags are purely declarative and cannot be affected by the build environment.

===

Anyway, the package now looks good to me.

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-uguid

FEDORA-2025-2024126625 (rust-uguid-2.2.1-3.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-2024126625

FEDORA-2025-2024126625 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-2024126625 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-2024126625

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-339c95a85e (rust-uguid-2.2.1-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-339c95a85e

FEDORA-2025-339c95a85e has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-339c95a85e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-339c95a85e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-2024126625 (rust-uguid-2.2.1-3.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-339c95a85e (rust-uguid-2.2.1-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.