Bug 2357907 (rust-ucs2)
| Summary: | Review Request: rust-ucs2 - UCS-2 decoding and encoding functions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gerd Hoffmann <kraxel> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/ucs2 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-04-21 01:51:27 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2357921 | ||||||
| Attachments: |
|
||||||
|
Description
Gerd Hoffmann
2025-04-07 14:10:34 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8867732 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2357907-rust-ucs2/fedora-rawhide-x86_64/08867732-rust-ucs2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > This is a dependency of the 'uefi' crate.
And what is pulling in the "uefi" crate? Just curious :)
The package looks good to me, but please regenerate it with rpmautospec.
It's a SHOULD for new Fedora packages, and has been the default for Rust packages for even longer.
spec url: https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/08874357-rust-ucs2/rust-ucs2.spec srpm url: https://download.copr.fedorainfracloud.org/results/kraxel/rust.misc/fedora-rawhide-x86_64/08874357-rust-ucs2/rust-ucs2-0.3.3-1.fc43.src.rpm Created attachment 2083895 [details]
The .spec file difference from Copr build 8867732 to 8874409
Copr build: https://copr.fedorainfracloud.org/coprs/build/8874409 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2357907-rust-ucs2/fedora-rawhide-x86_64/08874409-rust-ucs2/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. (In reply to Fabio Valentini from comment #2) > And what is pulling in the "uefi" crate? Just curious :) It's about having the packages available in fedora for development. My devel playground is here (not on crates.io yet): https://gitlab.com/kraxel/virt-firmware-rs/-/tree/main/efi-apps It's mostly testing efi apps. The one which might be interesting beyond that is netboot.efi. A challenge on the way to package that is that right now there seems to be no way to tell rust2rpm that something should be compiled for target $(arch)-unknown-uefi. The package looks good now, thanks. > It's about having the packages available in fedora for development. That's a noble goal, but not really something that rust-*devel packages are meant to support. If you can make it work for yourself, that's fine, but it's not generally something that is expected to work. > It's mostly testing efi apps. The one which might be interesting > beyond that is netboot.efi. A challenge on the way to package that > is that right now there seems to be no way to tell rust2rpm that > something should be compiled for target $(arch)-unknown-uefi. This probably will always require some manual work to tell cargo how to compile things ... I'm not sure if there's even *any* existing packages in Fedora that compile for "non-native" targets like that. Though it should be possible by replacing `%cargo_build` with the call to `cargo` and passing all necessary arguments. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ucs2 FEDORA-2025-bdc6a494b1 (rust-ucs2-0.3.3-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-bdc6a494b1 > > It's mostly testing efi apps. The one which might be interesting > > beyond that is netboot.efi. A challenge on the way to package that > > is that right now there seems to be no way to tell rust2rpm that > > something should be compiled for target $(arch)-unknown-uefi. > > This probably will always require some manual work to tell cargo how to > compile things ... I'm not sure if there's even *any* existing packages in > Fedora that compile for "non-native" targets like that. Though it should be > possible by replacing `%cargo_build` with the call to `cargo` and passing > all necessary arguments. That works indeed. https://copr.fedorainfracloud.org/coprs/kraxel/rust.vendor/package/rust-virtfw-efi-apps/ https://download.copr.fedorainfracloud.org/results/kraxel/rust.vendor/fedora-rawhide-x86_64/08890024-rust-virtfw-efi-apps/rust-virtfw-efi-apps.spec Does it make sense to add support to rust2rpm, or cargo-rpm-macros, or both? It'll probably continue to be something rarely used ... FEDORA-2025-bdc6a494b1 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-bdc6a494b1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-bdc6a494b1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-c3c1fae9c9 (rust-ucs2-0.3.3-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-c3c1fae9c9 FEDORA-2025-c3c1fae9c9 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-c3c1fae9c9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-c3c1fae9c9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-bdc6a494b1 (rust-ucs2-0.3.3-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-c3c1fae9c9 (rust-ucs2-0.3.3-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |