Bug 2358010

Summary: Do not attempt to perform any undo on "rbd mirror group promote --force" failure
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: Ilya Dryomov <idryomov>
Component: RBD-MirrorAssignee: Vinay Bhaskar <vvarada>
Status: CLOSED ERRATA QA Contact: aarsharm
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.1CC: ceph-eng-bugs, cephqe-warriors, sangadi, tserlin
Target Milestone: ---   
Target Release: 8.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ceph-19.2.1-166.el9cp Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-06-26 12:22:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ilya Dryomov 2025-04-07 18:14:08 UTC 
The "undo" code in Mirror::group_promote() is wrong both for orderly promote and force promote -- undoing promote should involve removing the promotion snapshot, not creating a demotion snapshot on top of it.  This should be relatively easy to fix for orderly promote, but force promote is complicated by the possibility of some member images having been rolled back or, even worse, rollback failing in the middle for one or more member image.  In this case the existing code would produce
a completely corrupted group.

Until rollbacks (and force promote sequence in general) are coordinated between member images such that it's easy to tell which step failed and where exactly the error is coming from, reliable undo is simply impossible.
Comment 5 errata-xmlrpc 2025-06-26 12:22:54 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat Ceph Storage 8.1 security, bug fix, and enhancement updates), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2025:9775