Bug 2358213
| Summary: | Review Request: chinese-segmentation - Chinese segmentation software | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Benson Muite <benson_muite> |
| Component: | Package Review | Assignee: | Tom.Rix |
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, Tom.Rix |
| Target Milestone: | --- | Flags: | Tom.Rix:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| URL: | https://gitee.com/openkylin/chinese-segmentation/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Benson Muite
2025-04-08 08:22:18 UTC
srpm link in broken, fedorpeople -> fedorapeople Edited it. Will likely need to update download link as Gitee requires authentication from most ip addresses, so may need to add a comment about that. Thanks for the update, I was able to run a local fedora-review, I think there is an issue with the source, here is the first part of the output. Issues: ======= - Dist tag is present. - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /sfs/fedora-review/review- chinese-segmentation/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ can you review your src and the upstream's ? Added a script to download from git spec: https://fed500.fedorapeople.org/chinese-segmentation.spec srpm: https://fed500.fedorapeople.org/chinese-segmentation-1.0.01-1.fc42.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/9381360 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358213-chinese-segmentation/fedora-rawhide-x86_64/09381360-chinese-segmentation/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. How are you running the fedora-review command? it is stumbling on source0,1
How are you getting this line ?
License: GPL-3.0-or-later AND MIT AND NTP
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
It looks like this project has a few bundled projects with their license files stripped out, these are the ones i could easily find.
This is the cppjieba/limonp is really this
https://github.com/yanyiwu/limonp/tree/master/include/limonp
And cppjiaba is really this
https://github.com/yanyiwu/cppjieba
A package can not strip other embedded license files.
|