Bug 2358521
| Summary: | Review Request: rust-icu_properties_data - Data for the icu_properties crate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/icu_properties_data | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-04-09 15:45:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2358527 | ||
|
Description
Ben Beasley
2025-04-08 23:49:54 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8875483 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358521-rust-icu_properties_data/fedora-rawhide-x86_64/08875483-rust-icu_properties_data/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. see https://bugzilla.redhat.com/show_bug.cgi?id=2358292#c6 for my reasoning why I would classify the files in data/macros/* as data in a weird format rather than generated code. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) Thank you for the review. I will document the rationale for the treatment of data in macros/. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-icu_properties_data FEDORA-2025-80aeba8de7 (rust-icu_properties_data-1.5.1-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-80aeba8de7 FEDORA-2025-80aeba8de7 (rust-icu_properties_data-1.5.1-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-04847cb65d (rust-icu_collections-1.5.0-3.fc42, rust-icu_locid-1.5.0-2.fc42, and 10 more) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-04847cb65d FEDORA-2025-cd87acc644 (rust-icu_collections-1.5.0-3.fc41, rust-icu_locid-1.5.0-2.fc41, and 10 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-cd87acc644 FEDORA-2025-e923d51676 (rust-icu_collections-1.5.0-3.fc40, rust-icu_locid-1.5.0-2.fc40, and 10 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-e923d51676 FEDORA-EPEL-2025-3fd4fbc045 (rust-atoi-2.0.0-2.el10_1, rust-detone-1.0.0-4.el10_1, and 15 more) has been submitted as an update to Fedora EPEL 10.1. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3fd4fbc045 FEDORA-EPEL-2025-c872f3c0bf (rust-atoi-2.0.0-2.el10_0, rust-detone-1.0.0-4.el10_0, and 16 more) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c872f3c0bf FEDORA-EPEL-2025-ef545b8853 (rust-atoi-2.0.0-2.el9, rust-icu_collections-1.5.0-3.el9, and 11 more) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-ef545b8853 FEDORA-EPEL-2025-ef545b8853 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-ef545b8853 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-04847cb65d has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-04847cb65d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-04847cb65d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-cd87acc644 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-cd87acc644 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-cd87acc644 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-e923d51676 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-e923d51676 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e923d51676 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-3fd4fbc045 has been pushed to the Fedora EPEL 10.1 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3fd4fbc045 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-c872f3c0bf has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c872f3c0bf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-ef545b8853 (rust-atoi-2.0.0-2.el9, rust-icu_collections-1.5.0-3.el9, and 11 more) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-04847cb65d has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-04847cb65d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-04847cb65d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-3fd4fbc045 has been pushed to the Fedora EPEL 10.1 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-3fd4fbc045 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-e923d51676 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-e923d51676` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e923d51676 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2025-c872f3c0bf has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c872f3c0bf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-04847cb65d (python-pydantic-core-2.27.2-5.fc42, rust-adblock-0.9.6-1.fc42, and 28 more) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2025-3fd4fbc045 (python-pydantic-core-2.23.4-2.el10_1, rust-adblock-0.9.6-1.el10_1, and 29 more) has been pushed to the Fedora EPEL 10.1 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2025-c872f3c0bf (rust-atoi-2.0.0-2.el10_0, rust-detone-1.0.0-4.el10_0, and 21 more) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-e923d51676 (python-pydantic-core-2.20.1-3.fc40, rust-adblock-0.9.6-1.fc40, and 28 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-cd87acc644 (python-pydantic-core-2.27.2-5.fc41, rust-adblock-0.9.6-1.fc41, and 28 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |