Bug 2358958
| Summary: | Review Request: rust-trim-in-place - In-place trimming strings | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Cristian Le <fedora> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://crates.io/crates/trim-in-place | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | rust-trim-in-place-0.1.7-1.fc43 | Doc Type: | --- | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-04-21 16:30:59 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2193253 | ||||||
| Attachments: |
|
||||||
|
Description
Cristian Le
2025-04-10 21:01:27 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8888316 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358958-rust-trim-in-place/fedora-rawhide-x86_64/08888316-rust-trim-in-place/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://lecris.fedorapeople.org/reviews/rust-trim-in-place/rust-trim-in-place.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-trim-in-place/rust-trim-in-place-0.1.7-1.fc43.src.rpm Moved the patches to `rust2rpm -p` Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=131518729 Created attachment 2084770 [details]
The .spec file difference from Copr build 8888316 to 8899933
Copr build: https://copr.fedorainfracloud.org/coprs/build/8899933 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2358958-rust-trim-in-place/fedora-rawhide-x86_64/08899933-rust-trim-in-place/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) === Note that I am *slightly* concerned by the code quality in this crate. It hasn't been updated in a while, and there is zero SAFETY documentation for any unsafe code in the crate. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-trim-in-place Thank you for the review, Fabio. For reference, zonyitoo/rust-ini#124 is the PR that added the dependency in rust-ini and it seems pretty straightforward to switch back if need arises. FEDORA-2025-89e0b9d19d (rust-trim-in-place-0.1.7-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-89e0b9d19d FEDORA-2025-89e0b9d19d (rust-trim-in-place-0.1.7-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-37a1582bc3 (rust-trim-in-place-0.1.7-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-37a1582bc3 FEDORA-2025-cde627076b (rust-trim-in-place-0.1.7-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-cde627076b FEDORA-2025-6066549ab6 (rust-trim-in-place-0.1.7-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-6066549ab6 FEDORA-2025-6066549ab6 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-6066549ab6` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-6066549ab6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-cde627076b has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-cde627076b` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-cde627076b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-37a1582bc3 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-37a1582bc3` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-37a1582bc3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-6066549ab6 (rust-trim-in-place-0.1.7-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-cde627076b (rust-trim-in-place-0.1.7-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-37a1582bc3 (rust-trim-in-place-0.1.7-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |