Bug 2359067 (rust-bitfield-struct)

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8890992
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2359067-rust-bitfield-struct/fedora-rawhide-x86_64/08890992-rust-bitfield-struct/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Looks good to me!

============================================================

I think this is your first package for a Rust crate?

I would recommend to familiarize yourself with how SemVer version requirements are mapped to RPM dependencies, and to consider the update process for library-only Rust crates that is slightly different from other packages in Fedora (with library updates usually merged to all branches, in line with an Updates Policy exception, to make maintenance easier).

If you have any questions, please stop by the #rust:fedoraproject.org room on Matrix (or send me an email, I guess, but Matrix is definitely preferred, since that doesn't make me Mr. Bus Factor One).

============================================================

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
❌ test suite is run and all unit tests pass
   (disabled due to missing dependencies - this is OK since defmt doesn't look trivial to package)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-bitfield-struct

> I think this is your first package for a Rust crate?

Third (after rust-ucs2 and rust-uguid).

> I would recommend to familiarize yourself with how SemVer version
> requirements are mapped to RPM dependencies, and to consider the update
> process for library-only Rust crates that is slightly different from other
> packages in Fedora (with library updates usually merged to all branches,

Ah, ok.  So rawhide + 42 + 41 + 40?

/me was planning for rawhide + 42, but adding the others too is easy enough.

FEDORA-2025-e02c02b31b (rust-bitfield-struct-0.10.1-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-e02c02b31b

FEDORA-2025-5e59faffb7 (rust-bitfield-struct-0.10.1-2.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-5e59faffb7

> Ah, ok.  So rawhide + 42 + 41 + 40?
> 
> /me was planning for rawhide + 42, but adding the others too is easy enough.

For new packages, that's usually not necessary.
But for updates for existing packages, we basically always merge changes to all active branches of Fedora (and EPEL, if present). Having the branches not diverge makes maintenance much easier (especially building security updates etc.)

FEDORA-2025-e02c02b31b has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-e02c02b31b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-e02c02b31b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-5e59faffb7 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-5e59faffb7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-5e59faffb7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-5e59faffb7 (rust-bitfield-struct-0.10.1-2.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-e02c02b31b (rust-bitfield-struct-0.10.1-2.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.