Bug 2359878
| Summary: | Review Request: gpgverify - signature verifier for easy and safe scripting | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Björn Persson <bjorn> | ||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, ngompa13, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | ngompa13:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://src.fedoraproject.org/rpms/gpgverify | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-05-09 09:11:23 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Björn Persson
2025-04-15 20:42:22 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8907820 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2359878-gpgverify/fedora-rawhide-x86_64/08907820-gpgverify/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Neal Gompa asked to be pinged. Taking this for review. Spec review:
> License: Boehm-GC
This is missing a license file in the sources that is installed along with the package. Can you please add one?
I thought it would be enough to have the license header in both files. If I make a separate license file, what do I write for a copyright notice in that file? SPDX requires the exact words "the above copyright notice", so the license file needs to contain some copyright notice for that phrase to refer to. Should I sort of merge the copyright notices of the script and the macro? Basically a file with a copy of the notice you have in the header is sufficient. License file added. https://www.Rombobjörn.se/packages/gpgverify-2.1-2/gpgverify.spec https://www.Rombobjörn.se/packages/gpgverify-2.1-2/gpgverify-2.1-2.fc43.src.rpm Created attachment 2088748 [details]
The .spec file difference from Copr build 8907820 to 9006683
Copr build: https://copr.fedorainfracloud.org/coprs/build/9006683 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2359878-gpgverify/fedora-rawhide-x86_64/09006683-gpgverify/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora packaging guidelines * Package licensing is correct and license data is installed * Package builds and installs * No serious issues from rpmlint PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/gpgverify Built, tested and submitted for Rawhide. Thanks for the review. |