Bug 2360112
| Summary: | Review Request: nginx-mod-brotli - NGINX module for Brotli compression | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mikel Olasagasti Uranga <mikel> | ||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | ngompa13:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/google/ngx_brotli | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-04-18 21:36:57 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Mikel Olasagasti Uranga
2025-04-16 11:30:43 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8909799 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2360112-nginx-mod-brotli/fedora-rawhide-x86_64/08909799-nginx-mod-brotli/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. Spec review: > %global upstream_tag 1.0.0rc You might want to consider breaking it up like so: %global baseversion 1.0.0 %global prerel rc %global upstream_tag %{baseversion}%{?prerel} Version: %{baseversion}%{?prerel:~%{prerel}} > Source: https://github.com/google/ngx_brotli/archive/refs/tags/v%{upstream_tag}.tar.gz This should be "%{url}/archive/v%{upstream_tag}/ngx_brotli-%{upstream_tag}.tar.gz > BuildRequires: libbrotli I took a look at this, and it looks like you need to unbundle brotli, as it's currently not using libbrotli at all. Once you fix that, then you should be able to use "brotli-devel" as a build dependency. I recommend adjusting the "config" script files to locate brotli through pkgconfig. You can see an example of how to do this in the nginx naxsi module code. Spec URL: https://mikel.olasagasti.info/tmp/fedora/nginx-mod-brotli.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/nginx-mod-brotli-1.0.0~rc-1.fc42.src.rpm - Applied suggested versioning and URL changes - Proposed upstream a change (172.patch) to restore the option to use system provided library and to use pkgconfig. The option to use system provided library was previously (150.patch) - Changed BR to use pkgconfig format Created attachment 2085305 [details]
The .spec file difference from Copr build 8909799 to 8911812
Copr build: https://copr.fedorainfracloud.org/coprs/build/8911812 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2360112-nginx-mod-brotli/fedora-rawhide-x86_64/08911812-nginx-mod-brotli/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correct * No serious issues from rpmlint PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/nginx-mod-brotli FEDORA-2025-f1f8466d9f (nginx-mod-brotli-1.0.0~rc-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-f1f8466d9f FEDORA-2025-f1f8466d9f (nginx-mod-brotli-1.0.0~rc-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. |