Bug 2360416
| Summary: | Review Request: intel-npu-driver - Intel Neural Processing Unit Driver | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ali Erdinc Koroglu <aekoroglu> | ||||
| Component: | Package Review | Assignee: | Adam Jackson <ajax> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | aekoroglu, ajax, ndegraef, package-review | ||||
| Target Milestone: | --- | Flags: | ajax:
fedora-review+
ndegraef: mirror+ |
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/intel/linux-npu-driver | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-08-15 05:45:57 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Ali Erdinc Koroglu
2025-04-16 18:20:09 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8911082 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2360416-intel-npu-driver/fedora-rawhide-x86_64/08911082-intel-npu-driver/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Quick notes: - The base package probably wants to say Requires: oneapi-level-zero so the loader gets (maybe Suggests but Requires feels better to me) - The -devel package probably shouldn't exist, upstream should just not install the ".so" file since libze_loader will always open the versioned filename. SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/09132173-intel-npu-driver/intel-npu-driver.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/09132173-intel-npu-driver/intel-npu-driver-1.16.0-1.fc43.src.rpm @ajax and @ndegraef fyi Created attachment 2093009 [details]
The .spec file difference from Copr build 8911082 to 9132416
Copr build: https://copr.fedorainfracloud.org/coprs/build/9132416 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2360416-intel-npu-driver/fedora-rawhide-x86_64/09132416-intel-npu-driver/fedora-review/review.txt Found issues: - Unversioned so-files directly in %_libdir. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > - Unversioned so-files directly in %_libdir. The unversioned .so symlink in intel-npu-driver-1.16.0-1.fc42.x86_64.rpm should be removed in the %install phase. As mentioned in comment #2, the level zero loader will always open libze_intel_npu.so.1 and never libze_intel_npu.so. Since the driver is not intended to be linked directly but rather always dlopened, there should not be an unversioned .so symlink for it lest ld(1) link to it. Package looks good otherwise. SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/09247318-intel-npu-driver/intel-npu-driver.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/09247318-intel-npu-driver/intel-npu-driver-1.16.0-1.fc43.src.rpm @ajax fyi LGTM, approved. @aekoroglu : jfyi, this is now ready for requesting a Git repository for the Fedora Pagure Bug should be assigned to someone 1st The Pagure repository was created at https://src.fedoraproject.org/rpms/intel-npu-driver Thank you @ajax and @ndegraef https://koji.fedoraproject.org/koji/buildinfo?buildID=2791352 |