Bug 2361095
| Summary: | Review Request: vhs - Your CLI home video recorder | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Carl George 🤠<carl> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/charmbracelet/vhs | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-04-20 00:46:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Carl George ðŸ¤
2025-04-19 05:29:46 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8921780 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2361095-vhs/fedora-rawhide-x86_64/08921780-vhs/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Not a valid SPDX expression 'Apache-2.0 AND BSD-3-Clause AND MIT AND MPL-2.0 AND AND OFL-1.1'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora packaging guidelines * Package follows guidelines for bundled dependencies * Package licensing is correct and license files are installed * The "error" about the license expression seems to be a false positive around OFL-1.1? * Package builds and installs * No serious issues from rpmlint Note, the Go SIG is working on new tooling to simplify working with vendored dependencies. You may want to check with them to see if this spec can be simplified. PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/vhs > * The "error" about the license expression seems to be a false positive around OFL-1.1? Nah it looks like I accidentally had a double AND in the expression. I just fixed it on import to dist-git. > Note, the Go SIG is working on new tooling Yeah I've heard a bit about this, and will convert to it in the future if it becomes required. For now this works. Thanks for the review! FEDORA-2025-f3192bf45a (vhs-0.9.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-f3192bf45a FEDORA-2025-f3192bf45a (vhs-0.9.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-686a541f2d (vhs-0.9.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-686a541f2d FEDORA-2025-686a541f2d has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-686a541f2d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-686a541f2d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-686a541f2d (vhs-0.9.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |