Bug 2361181

Summary:	Review Request: R-RcppTOML - 'Rcpp' Bindings to Parser for "Tom's Obvious Markup Language"
Product:	[Fedora] Fedora	Reporter:	Iñaki Ucar <i.ucar86>
Component:	Package Review	Assignee:	Tom "spot" Callaway <spotrh>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, spotrh
Target Milestone:	---	Flags:	spotrh: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://cran.r-project.org/package=%{packname}
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-04-21 16:15:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Iñaki Ucar 2025-04-19 21:44:53 UTC

Spec URL: https://iucar.fedorapeople.org/pkgs/R-RcppTOML.spec
SRPM URL: https://iucar.fedorapeople.org/pkgs/R-RcppTOML-0.2.3-1.fc43.src.rpm

Description:
The configuration format defined by 'TOML' (which expands to "Tom's
Obvious Markup Language") specifies an excellent format (described
at <https://toml.io/en/>) suitable for both human editing as well as
the common uses of a machine-readable format. This package uses 'Rcpp'
to connect to the 'toml++' parser written by Mark Gillard to R.

Fedora Account System Username: iucar

Comment 1 Fedora Review Service 2025-04-19 21:59:22 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8938052
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2361181-r-rcpptoml/fedora-rawhide-x86_64/08938052-R-RcppTOML/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Tom "spot" Callaway 2025-04-21 15:34:14 UTC

Everything here looks solid, standard R module packaging, you can ignore the missing BuildRequires: gcc-c++, because you inherit it from R-core-devel.

APPROVED

Comment 3 Fedora Admin user for bugzilla script actions 2025-04-21 15:55:28 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/R-RcppTOML

Comment 4 Iñaki Ucar 2025-04-21 15:56:46 UTC

Thanks!

Comment 5 Fedora Update System 2025-04-21 16:08:09 UTC

FEDORA-2025-16d7f64bc7 (R-RcppTOML-0.2.3-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-16d7f64bc7

Comment 6 Fedora Update System 2025-04-21 16:15:58 UTC

FEDORA-2025-16d7f64bc7 (R-RcppTOML-0.2.3-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.