Bug 2361191
Summary: | Falkon 25.04 segfaults on launch attempt. | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Stan Trzmiel <xeno> |
Component: | falkon | Assignee: | Kevin Kofler <kevin> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | urgent | Docs Contact: | |
Priority: | unspecified | ||
Version: | 42 | CC: | derekenz, farchord, kde-sig, kevin |
Target Milestone: | --- | Keywords: | Desktop |
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | falkon-25.04.0-3.fc42 | Doc Type: | --- |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2025-04-23 01:48:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Stan Trzmiel
2025-04-19 23:10:20 UTC
This looks clearly like an upstream regression to me. The relevant thread in the backtrace is this one: Thread 1 (Thread 0x7f6e92cde900 (LWP 55067)): [KCrash Handler] #5 BrowserWindow::statusBar (this=0x0) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/app/browserwindow.cpp:684 #6 0x00007f6eae2f0023 in BookmarksTools::addFolderToMenu (receiver=receiver@entry=0x5634bea6f170, menu=menu@entry=0x5634bea700e0, folder=0x5634bea7bab0) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/bookmarks/bookmarkstools.cpp:394 #7 0x00007f6eae2ef400 in BookmarksTools::addActionToMenu (receiver=receiver@entry=0x5634bea6f170, menu=menu@entry=0x5634bea700e0, item=<optimized out>) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/bookmarks/bookmarkstools.cpp:373 #8 0x00007f6eae2ef4c2 in BookmarksTools::addFolderContentsToMenu (receiver=0x5634bea6f170, menu=0x5634bea700e0, folder=<optimized out>) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/bookmarks/bookmarkstools.cpp:446 #9 0x00007f6eae2ef686 in BookmarksToolbarButton::createMenu (this=<optimized out>) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/bookmarks/bookmarkstoolbarbutton.cpp:140 #10 0x00007f6eae2ef768 in BookmarksToolbarButton::init (this=<optimized out>) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/bookmarks/bookmarkstoolbarbutton.cpp:239 #11 0x00007f6eae2ef7be in BookmarksToolbarButton::BookmarksToolbarButton (this=0x5634bea6f170, bookmark=0x5634bea7ba10, parent=<optimized out>, this=<optimized out>, bookmark=<optimized out>, parent=<optimized out>) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/bookmarks/bookmarkstoolbarbutton.cpp:45 #12 0x00007f6eae2ef822 in BookmarksToolbar::addItem (this=0x5634be99a110, item=0x5634bea7ba10) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/bookmarks/bookmarkstoolbar.cpp:235 #13 0x00007f6eae2ef8ef in BookmarksToolbar::refresh (this=0x5634be99a110) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/bookmarks/bookmarkstoolbar.cpp:124 #14 0x00007f6eae2efefc in BookmarksToolbar::BookmarksToolbar (this=<optimized out>, window=<optimized out>, parent=<optimized out>, this=<optimized out>, window=<optimized out>, parent=<optimized out>) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/bookmarks/bookmarkstoolbar.cpp:65 #15 0x00007f6eae298e16 in BrowserWindow::setupUi (this=this@entry=0x5634be8ae0d0) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/app/browserwindow.cpp:373 #16 0x00007f6eae299f88 in BrowserWindow::BrowserWindow (this=0x5634be8ae0d0, type=Qz::BW_FirstAppWindow, startUrls=..., this=<optimized out>, type=<optimized out>, startUrls=...) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/app/browserwindow.cpp:206 #17 0x00007f6eae2a8773 in MainApplication::createWindow (this=this@entry=0x7fff7b9afab0, type=type@entry=Qz::BW_FirstAppWindow, startUrls=...) at /usr/include/qt6/QtCore/qarraydata.h:60 #18 0x00007f6eae2af049 in MainApplication::MainApplication (this=this@entry=0x7fff7b9afab0, argc=@0x7fff7b9afa2c: 1, argv=<optimized out>, this=<optimized out>, argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/lib/app/mainapplication.cpp:350 #19 0x000056349b219b59 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/falkon-25.04.0-2.fc42.x86_64/src/main/main.cpp:67 "BrowserWindow::statusBar (this=0x0)" really says it all. This is the opposite of the classic use-after-free, a use-before-allocation. BookmarkTools::addFolderToMenu tries to request the status bar of a browser window that is still being constructed. Unfortunately, the broken update is already headed to stable and the push is already ongoing (and was already ongoing when you filed the bug), so I guess there is no way to prevent this from hitting all users anymore. It is a real problem that updates that include a completely broken Falkon can get all-positive karma. This is a result of the KDE SIG decision to default to Firefox instead of Falkon, unfortunately. Lack of testing of Falkon is an unavoidable result of this wrong decision. (Note that I have given -1 votes to the Fedora 41 and 40 updates, so hopefully at least those will NOT go out until fixed.) I think this fix: https://invent.kde.org/network/falkon/-/commit/164475bf836ebf96874c227e0cd3c91aa33f4de7 for another crash at startup: https://bugs.kde.org/show_bug.cgi?id=501535 introduced this new one. I tried installing Falkon 25.04 and starting it, I get no crash here, it seems to be working fine. Have you tried wiping your user settings? Installed Falkon 25.04 from Flathub. Running F42 KDE Plasma 6.3.4 QT 6.8.2 Kernel 6.14.2-300 Bare metal. Falkon 25.04 is running fine so far. Cannot repro the issue. From the backtrace, I assume that the crash only happens if you have bookmarks in the menu, possibly only with subfolders. So wiping the bookmarks will probably make the crash go away, but it is not a fix and it loses data. Note that long-time installs upgraded from one Fedora release to the next will have a "Fedora Bookmarks" subfolder with several subsubfolders in the bookmarks menu by default. That might not be the case for fresh installs anymore (not sure), but for upgraded installs, it is the normal case. (In reply to Kevin Kofler from comment #3) > I think this fix: > https://invent.kde.org/network/falkon/-/commit/ > 164475bf836ebf96874c227e0cd3c91aa33f4de7 > for another crash at startup: > https://bugs.kde.org/show_bug.cgi?id=501535 > introduced this new one. Actually, the fix did not introduce the new crash, it just did not fix it. Looks like addFolderToMenu needs the same kind of fix upstream made in addUrlToMenu, connecting to a lambda rather than directly to mApp->getWindow()->statusBar() that is not yet constructed at that point. So something like: - QObject::connect(m, &QMenu::aboutToHide, mApp->getWindow()->statusBar(), &StatusBar::clearMessage); + QObject::connect(m, &QMenu::aboutToHide, [=]() { + mApp->getWindow()->statusBar()->clearMessage(); + }); … - QObject::connect(act, &QAction::hovered, mApp->getWindow()->statusBar(), &StatusBar::clearMessage); + QObject::connect(act, &QAction::hovered, [=]() { + mApp->getWindow()->statusBar()->clearMessage(); + }); Yes I do see the subfolders. Adding bookmarks as I go. So far it seems ok. Ok added a new folder to the Bookmarks Bar. Created a subfolder within the new folder. Falkon crashed on startup. The updated Falkon has been untagged and removed from the update. Upstream fix: https://invent.kde.org/network/falkon/-/commit/dca93d08742f7c4ed66831ae1bea6078ffc7d716 This is basically what I suggested, but with the addition of one third spot that I had missed (in the addSeparatorToMenu method). FEDORA-2025-aa9bcfdea1 (falkon-25.04.0-3.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-aa9bcfdea1 Confirmed, falkon-25.04.0-3 fixes the issue. The new update fixes the issue. Falkon-25.04.0-3.fc42 works as expected. Subfolders work fine and do not create a crash. FEDORA-2025-92b73e3acc (falkon-25.04.0-3.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-92b73e3acc FEDORA-2025-b832fbe8b0 (falkon-25.04.0-3.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b832fbe8b0 FEDORA-2025-aa9bcfdea1 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-aa9bcfdea1` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-aa9bcfdea1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-aa9bcfdea1 (falkon-25.04.0-3.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-b832fbe8b0 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b832fbe8b0` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b832fbe8b0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-92b73e3acc has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-92b73e3acc` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-92b73e3acc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-92b73e3acc (falkon-25.04.0-3.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-b832fbe8b0 (falkon-25.04.0-3.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |