Bug 236121
| Summary: | LSPP: racoon has a buffer overflow when receiving large security context from kernel | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Joy Latten <latten> | ||||||
| Component: | ipsec-tools | Assignee: | Steve Conklin <sconklin> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | David Lawrence <dkl> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 5.0 | CC: | iboverma, joe, krisw, linda.knippers, sgrubb | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | powerpc | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | RHSA-2007-0342 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2007-06-27 14:14:38 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 224041 | ||||||||
| Attachments: |
|
||||||||
|
Description
Joy Latten
2007-04-12 00:32:10 UTC
Joy, do you want me to write the patch for this or are you working on it? I think its a matter of changing ctx_str to be a pointer to memory rather than an array and adding the allocation/free calls. Steve, that would be great, thanks! Created attachment 152458 [details]
patch increasing buffer size
This is a quick and dirty patch that will let people continue testing. A better
patch would allocate security_ctx as a variable sized struct.
Created attachment 152467 [details]
Check that security context string doesn't overflow the buffer.
Steve bumping up MAX for security context string length sounds ok to me.
I also included this patch to make sure we check for buffer overflow.
ipsec-tools-0.6.5-6.4 was built with both of the above patches. Retest is needed. I am using the new ipsec-tools and racoon and all appears to be working well. Consider this retested. |