Bug 2361641
| Summary: | Review Request: rust-migrations_macros - Codegeneration macros for diesels embedded migrations | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jelle van der Waa <jvanderwaa> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/migrations_macros | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-05-26 15:05:12 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Jelle van der Waa
2025-04-22 13:10:16 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8951874 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2361641-rust-migrations_macros/fedora-rawhide-x86_64/08951874-rust-migrations_macros/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-migrations_macros Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The spec file in the SRPM and the one linked directly don't match - one uses rpmautospec, the other one doesn't. Please reconcile both versions (i.e. to use rpmautospec). Sorry, seems I held my spec file in git causing these unwanted changes after a `fedpkg mockbuild`. The correct spec and src rpm should be: https://download.copr.fedorainfracloud.org/results/jelly/rust-migrations_macros/fedora-rawhide-x86_64/09025048-rust-migrations_macros/rust-migrations_macros.spec https://download.copr.fedorainfracloud.org/results/jelly/rust-migrations_macros/fedora-rawhide-x86_64/09025048-rust-migrations_macros/rust-migrations_macros-2.2.0-1.fc43.src.rpm BTW, this package used to be in Fedora in the past https://src.fedoraproject.org/rpms/rust-migrations_macros Created attachment 2089601 [details]
The .spec file difference from Copr build 8951874 to 9027160
Copr build: https://copr.fedorainfracloud.org/coprs/build/9027160 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2361641-rust-migrations_macros/fedora-rawhide-x86_64/09027160-rust-migrations_macros/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-migrations_macros Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good to me now, thank you! You can continue with the unretirement now. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) FEDORA-2025-a00cfa2938 (rust-migrations_macros-2.2.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-a00cfa2938 FEDORA-2025-a00cfa2938 (rust-migrations_macros-2.2.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. |