Bug 2362059
| Summary: | Review Request: xwayland-satellite - Rootless Xwayland integration for Wayland compositors | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://github.com/Supreeeme/xwayland-satellite | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-05-20 00:03:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabio Valentini
2025-04-24 14:05:56 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=131937315 Copr build: https://copr.fedorainfracloud.org/coprs/build/8963801 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362059-xwayland-satellite/fedora-rawhide-x86_64/08963801-xwayland-satellite/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in xwayland-satellite Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Note: This is currently built with vendored dependencies due to a large-ish number of missing packages for Rust crates. I would work on packaging the missing dependencies so that this package can be switched to non-vendored dependencies eventually. Taking this review. Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ latest version packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines (using vendored crates for now) Note: consider seeing if using wlheadless-run lets you run the test suite. Not blocking this on that though. Package APPROVED. === Recommended post-import tasks: - set up package on release-monitoring.org: - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review! I'll take a look at wlheadless-run, though at first glance it looks like it would be hard to integrate into the %cargo_test macro :( I'll also look into packaging the missing dependencies so this doesn't need to build with vendored dependencies forever. The Pagure repository was created at https://src.fedoraproject.org/rpms/xwayland-satellite Imported and built: https://koji.fedoraproject.org/koji/buildinfo?buildID=2717034 |