Bug 2362060
| Summary: | Review Request: niri - Scrollable-tiling Wayland compositor | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://github.com/YaLTeR/niri | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-05-20 13:17:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabio Valentini
2025-04-24 14:13:22 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=131937050 Note: This package builds with vendored dependencies, in part based on how the packages for COSMIC work since they share some similarities. Notably, the dependency on smithay (the Wayland compositor library) is a git snapshot, which would need to be vendored anyway. Copr build: https://copr.fedorainfracloud.org/coprs/build/8963813 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2362060-niri/fedora-rawhide-x86_64/08963813-niri/fedora-review/review.txt Found issues: - Systemd user unit service file(s) in niri Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ latest version packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines (using vendored crates for now) Note: consider seeing if using wlheadless-run lets you run the test suite. Not blocking this on that though. Package APPROVED. === Recommended post-import tasks: - set up package on release-monitoring.org: - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thank you for the review! I forgot about xwayland-run et al, I'll take a look if it can be used to run the tests. I'll look into updating to 25.05 too, it was released a few days ago and looks like a great release. The Pagure repository was created at https://src.fedoraproject.org/rpms/niri Imported, updated to 25.05, and built: https://bodhi.fedoraproject.org/updates/FEDORA-2025-4ec8af6ae3 |