Bug 236240

Summary: CVE-2007-2348 lftp mirror --script does not escape names and targets of symbolic links
Product: [Fedora] Fedora Reporter: Lubomir Kundrak <lkundrak>
Component: lftpAssignee: Martin Nagy <mnagy>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: 6CC: hripps, mbarabas
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://lftp.yar.ru/news.html
Whiteboard: impact=low,source=gentoo,reported=20070405,public=20070109
Fixed In Version: lftp-3.5.10-4.fc7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-01-05 20:09:03 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Lubomir Kundrak 2007-04-12 12:49:45 EDT
+++ This bug was initially created as a clone of Bug #236238 +++

Description of problem:

Does not escape names of symlinks when producing a script to be
passed to the shell, which could be abused by an attacked to
trick the user into executing arbitrary code with crafted symbolic
link.

Version-Release number of selected component (if applicable):

        Doesn't Affect: RHEL2.1 no support for --script
        Doesn't Affect: RHEL3 ditto
        Affects: RHEL4
        Affects: RHEL5
        Affects: FC5
        Affects: FC6

Steps to Reproduce:
1. ln -s '$(touch /tmp/gotya; echo kwak)' malicious
2. serve that file via ftp and attempt to download it with lftp via mirror --script
3. Try to run the resulting script with lftp -f
  
Actual results:

The downloaded file will point to "kwak", while file /tmp/gotya will be
created.

Additional info:

The security implications are questionable, as is the usefullness of the
--script feature itself.
Comment 1 Till Maas 2008-01-05 20:09:03 EST
In Fedora 7, there is lftp-3.5.10-4.fc7, which has this vulnerability fixed.