Bug 2363658
| Summary: | Review Request: rust-outref - Out reference | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://crates.io/crates/outref | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-05-31 02:04:59 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2426767 | ||||||
| Attachments: |
|
||||||
|
Description
Ankur Sinha (FranciscoD)
2025-05-02 12:40:41 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/8989445 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363658-rust-outref/fedora-rawhide-x86_64/08989445-rust-outref/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. There's a bunch of files that would be great to exclude from packages (and potentially excluded upstream from published crates): - /.github/ - /justfile Adding a setting like this under the [package] table in Cargo.toml should do it: ``` [package] # ... exclude = ["/.github/", "/justfile"] # ... ``` Thanks for the review, Fabio. I've updated the spec/srpm to remove these files. I'll file an issue/PR upstream too now. Spec URL: https://ankursinha.fedorapeople.org/rust-outref/rust-outref.spec SRPM URL: https://ankursinha.fedorapeople.org/rust-outref/rust-outref-0.5.2-2.fc43.src.rpm Cheers Created attachment 2089526 [details]
The .spec file difference from Copr build 8989445 to 9023948
Copr build: https://copr.fedorainfracloud.org/coprs/build/9023948 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363658-rust-outref/fedora-rawhide-x86_64/09023948-rust-outref/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thank you, looks good to me now. Please don't forget to file that upstream PR :) === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-outref FEDORA-2025-eddfe33103 (rust-outref-0.5.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-eddfe33103 FEDORA-2025-eddfe33103 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-eddfe33103 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-eddfe33103 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-eddfe33103 (rust-outref-0.5.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |