Bug 2363808

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8992715
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363808-trafix/fedora-rawhide-x86_64/08992715-trafix/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Source SRPM: https://github.com/msoodb/trafix/releases/download/v1.0.7/trafix-1.0.7-1.fc42.src.rpm

Created attachment 2088457 [details]
The .spec file difference from Copr build 8992715 to 8996844

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8996844
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363808-trafix/fedora-rawhide-x86_64/08996844-trafix/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> %global debug_package %{nil}
> [...]
> strip %{buildroot}%{_bindir}/trafix
No-go. Debuginfo is required.

> %build
> %set_build_flags
Calling %set_build_flags manually is not needed since Fedora 36.

> %check
> # No test suite upstream; basic functionality tested manually.
Remove this, then. The %check section is not mandatory.

> %dir /etc/trafix
> %config(noreplace) /etc/trafix/config.cfg
Use %{_sysconfdir} instead of hard-coding /etc.

Hi, Thank you. issues were fixed now.

Source SRPM: https://github.com/msoodb/trafix/releases/download/v1.0.9/trafix-1.0.9-1.fc42.src.rpm

Created attachment 2088507 [details]
The .spec file difference from Copr build 8996844 to 8998105

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8998105
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363808-trafix/fedora-rawhide-x86_64/08998105-trafix/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Source SRPM: https://github.com/msoodb/trafix/releases/download/v1.1.0/trafix-1.1.0-1.fc42.src.rpm

Created attachment 2088767 [details]
The .spec file difference from Copr build 8998105 to 9007108

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9007108
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363808-trafix/fedora-rawhide-x86_64/09007108-trafix/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Mock review

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GNU General Public License, Version 3", "Unknown or
     generated". 1 files have unknown license. Detailed output of
     licensecheck in /var/lib/copr-rpmbuild/results/trafix/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[?]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 3863 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: trafix-1.1.0-1.fc43.x86_64.rpm
          trafix-1.1.0-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpr6wo5w7_')]
checks: 32, packages: 2

trafix.x86_64: W: position-independent-executable-suggested /usr/bin/trafix
trafix.spec: W: no-%check-section
 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 badness; has taken 0.2 s 




Rpmlint (debuginfo)
-------------------
Checking: trafix-debuginfo-1.1.0-1.fc43.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpnysesc1s')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.1 s 





Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "trafix-debuginfo".
(none): E: there is no installed rpm "trafix".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://github.com/msoodb/trafix/releases/download/v1.1.0/trafix-1.1.0.tar.gz :
  CHECKSUM(SHA256) this package     : f8a5087579475940ae6b63464de2a2f3fceb10cad1267abd99ba26cf54c2885d
  CHECKSUM(SHA256) upstream package : f8a5087579475940ae6b63464de2a2f3fceb10cad1267abd99ba26cf54c2885d


Requires
--------
trafix (rpmlib, GLIBC filtered):
    config(trafix)
    libc.so.6()(64bit)
    libncurses.so.6()(64bit)
    libpcap.so.1()(64bit)
    libtinfo.so.6()(64bit)
    lm_sensors
    rtld(GNU_HASH)



Provides
--------
trafix:
    config(trafix)
    trafix
    trafix(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name trafix --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, C/C++, Generic
Disabled plugins: Ocaml, R, fonts, PHP, Perl, Python, Java, SugarActivity, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment:
a) Include all documentation files
%doc README.md docs/trafix_features.md docs/trafix_technical_doc.md

Good feedback.

Please replace
Source0:        %{url}/releases/download/v%{version}/%{name}-%{version}.tar.gz
by
Source0:        %{url}/archive/%{version}/trafix-%{version}.tar.gz
  
see https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags
could also use forge macros
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control

To preserve timestamps, replace
install -Dm644 man/trafix.1 %{buildroot}%{_mandir}/man1/trafix.1
install -Dm644 config/config.cfg %{buildroot}/etc/trafix/config.cfg

by

install -Dpm644 man/trafix.1 %{buildroot}%{_mandir}/man1/trafix.1
install -Dpm644 config/config.cfg %{buildroot}/etc/trafix/config.cfg

Thanks for the excellent feedback! I've implemented both suggestions:

1- Updated Source0 to use the GitHub archive format following Fedora packaging guidelines
2- Added -p flag to install commands to preserve timestamps

All changes are now committed and ready. The spec file follows the recommended Fedora practices and RPM maintainers can fetch
 sources directly from GitHub archives.

Please consider to post links to updated spec file and srpm.

On the other hand, if you, by the last comment, want to others to maintain the package or you want maintain package elsewere
than Fedora proper, please close the ticket here.

latest 
Source RPM: https://github.com/msoodb/trafix/releases/download/v1.0.1/trafix-1.0.1-1.fc42.src.rpm

Created attachment 2110701 [details]
The .spec file difference from Copr build 9007108 to 9729530

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9729530
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363808-trafix/fedora-rawhide-x86_64/09729530-trafix/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> %global debug_package %{nil}
Once again, this is not allowed. Debuginfo is required in Fedora.

> %build
> %set_build_flags
Calling %set_build_flags manually is not needed since Fedora 36.

> install -Dm644 man/trafix.1 %{buildroot}%{_mandir}/man1/trafix.1
Use "install -p" to preserve file timestamps.

> %check
> # No test suite upstream; basic functionality tested manually.
The %check section is not mandatory. If it's empty, you can just remove it.