Bug 2363808

Summary: Review Request: trafix - A terminal-based monitoring tool for Linux
Product: [Fedora] Fedora Reporter: masoud bolhassani <masoud.bolhassani>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 42CC: fedora, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---   
Hardware: x86_64   
OS: Linux   
URL: https://github.com/msoodb/trafix/releases/download/v1.0.4/trafix-1.0.4-1.fc42.src.rpm
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .spec file difference from Copr build 8992715 to 8996844
none
The .spec file difference from Copr build 8996844 to 8998105
none
The .spec file difference from Copr build 8998105 to 9007108 none

Description masoud bolhassani 2025-05-02 18:25:23 UTC
Review Request: trafix - A terminal-based monitoring tool for Linux

Description:
I would like to request a review of my application, trafix, for inclusion in the Fedora repositories.

    Name: trafix
    Version: 1.0.3
    Upstream URL: https://github.com/msoodb/trafix
    Source tarball: https://github.com/msoodb/trafix/releases/download/v1.0.4/trafix-1.0.4-1.fc42.src.rpm

Description of the Application:
Trafix is a terminal-based network monitoring tool for Linux, which provides real-time network statistics including IP, gateway, DNS, Wi-Fi SSID, signal strength, bitrate, frequency, MAC address, and other network metrics.

I have followed the Fedora packaging guidelines and prepared the RPM spec file.

Please review my package to ensure it meets the necessary criteria to be included in Fedora.

Thank you for your time and review.
Reproducible: Always


Reproducible: Always

Comment 1 Fedora Review Service 2025-05-03 05:01:53 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8992715
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363808-trafix/fedora-rawhide-x86_64/08992715-trafix/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2025-05-05 12:54:20 UTC
Created attachment 2088457 [details]
The .spec file difference from Copr build 8992715 to 8996844

Comment 4 Fedora Review Service 2025-05-05 12:54:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8996844
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363808-trafix/fedora-rawhide-x86_64/08996844-trafix/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Artur Frenszek-Iwicki 2025-05-05 15:49:27 UTC
> %global debug_package %{nil}
> [...]
> strip %{buildroot}%{_bindir}/trafix
No-go. Debuginfo is required.

> %build
> %set_build_flags
Calling %set_build_flags manually is not needed since Fedora 36.

> %check
> # No test suite upstream; basic functionality tested manually.
Remove this, then. The %check section is not mandatory.

> %dir /etc/trafix
> %config(noreplace) /etc/trafix/config.cfg
Use %{_sysconfdir} instead of hard-coding /etc.

Comment 6 masoud bolhassani 2025-05-05 17:31:16 UTC
Hi, Thank you. issues were fixed now.

Source SRPM: https://github.com/msoodb/trafix/releases/download/v1.0.9/trafix-1.0.9-1.fc42.src.rpm

Comment 7 Fedora Review Service 2025-05-05 17:36:24 UTC
Created attachment 2088507 [details]
The .spec file difference from Copr build 8996844 to 8998105

Comment 8 Fedora Review Service 2025-05-05 17:36:27 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8998105
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363808-trafix/fedora-rawhide-x86_64/08998105-trafix/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Fedora Review Service 2025-05-07 10:46:27 UTC
Created attachment 2088767 [details]
The .spec file difference from Copr build 8998105 to 9007108

Comment 11 Fedora Review Service 2025-05-07 10:46:29 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9007108
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363808-trafix/fedora-rawhide-x86_64/09007108-trafix/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.