Bug 236430
Summary: | nfsd: BUG: using smp_processor_id() in preemptible code | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise MRG | Reporter: | IBM Bug Proxy <bugproxy> | ||||||||
Component: | realtime-kernel | Assignee: | Clark Williams <williams> | ||||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||||||
Severity: | urgent | Docs Contact: | |||||||||
Priority: | medium | ||||||||||
Version: | 1.0 | ||||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | 2.6.21-31.el5rt | Doc Type: | Bug Fix | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2007-06-20 16:20:17 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
Description
IBM Bug Proxy
2007-04-13 20:52:47 UTC
Created attachment 152589 [details]
breaknfs testcase
----- Additional Comments From sripathi.com (prefers email at sripathik.com) 2007-04-14 11:11 EDT ------- I recreated this problem in another, easier way. I just started oprofile and stopped it. I then saw the following message in dmesg. Though nfsd is not involved here, it seems to be the same problem. BUG: using smp_processor_id() in preemptible [00000000] code: oprofiled/29202 caller is drain_array+0x25/0x132 Call Trace: [<ffffffff8026d828>] dump_trace+0xbd/0x3d8 [<ffffffff8026db87>] show_trace+0x44/0x6d [<ffffffff8026ddc8>] dump_stack+0x13/0x15 [<ffffffff80355e2e>] debug_smp_processor_id+0xe3/0xf1 [<ffffffff802e01b5>] drain_array+0x25/0x132 [<ffffffff802e07ac>] __cache_shrink+0xd5/0x1a6 [<ffffffff802e0a47>] kmem_cache_destroy+0x6c/0xe3 [<ffffffff80314be9>] dcookie_unregister+0x109/0x121 [<ffffffff8843af63>] :oprofile:event_buffer_release+0x1f/0x43 [<ffffffff80212992>] __fput+0xc3/0x185 [<ffffffff8022e537>] fput+0x14/0x16 [<ffffffff802252cd>] filp_close+0x63/0x6e [<ffffffff80239cac>] put_files_struct+0x69/0xb8 [<ffffffff802158a8>] do_exit+0x27d/0x8ad [<ffffffff8024af12>] cpuset_exit+0x0/0x70 [<ffffffff8024ea66>] sys_exit_group+0x12/0x14 [<ffffffff8025f42c>] tracesys+0x151/0x1be [<00000034ece948cf>] --------------------------- | preempt count: 00000001 ] | 1-level deep critical section nesting: ---------------------------------------- .. [<ffffffff80355ddb>] .... debug_smp_processor_id+0x90/0xf1 .....[<ffffffff802e01b5>] .. ( <= drain_array+0x25/0x132) changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|RH236430 - nfsd: BUG: using |RH236430 - BUG: using |smp_processor_id() in |smp_processor_id() in |preemptible code |preemptible code ------- Additional Comments From ankigarg.com (prefers email at ankita.com) 2007-04-15 04:52 EDT ------- Changing summary to make it more general Created attachment 152770 [details]
fix_drain_array.patch
----- Additional Comments From ankigarg.com (prefers email at ankita.com) 2007-04-17 01:50 EDT ------- fix drain_array in mm/slab.c With this patch, I have not seen the BUG report in 24 hours of the test run. Working on investigating if this change would affect the kmem_cache_t control path. ----- Additional Comments From ankigarg.com (prefers email at ankita.com) 2007-04-17 07:38 EDT ------- This patch is just a workaround and does not fix the underlying problem. So, investigating further. Created attachment 152870 [details]
fix_drain_array.patch
----- Additional Comments From ankigarg.com (prefers email at ankita.com) 2007-04-18 00:52 EDT ------- drain_array_fix.patch This patch fixes the BUG in drain_array() function. Found that there is no need to call smp_processor_id from drain_array(), as already the call to slab_spin_lock_irq() fills the value of this_cpu using raw_smp_processor_id(). ----- Additional Comments From ankigarg.com (prefers email at ankita.com) 2007-04-18 09:30 EDT ------- Posted patch to lkml and Ingo Thanks for investigating and proposing fix! Assigning to Ingo. We'll discuss w/ him on this Friday's internal call. ----- Additional Comments From ankigarg.com (prefers email at ankita.com) 2007-04-19 01:02 EDT ------- Tim, Ingo has accepted the fix! ok, reasigning this to Clark to throw it into the patch heap. The patch should be in any kernel-rt above 2.6.20-25. I believe it's also in all the 2.6.21-rtX series. We'll let this ride for a while and if no one sees it in a week or so, we'll declare victory and close it. |