Bug 236486

This my first package and I need a sponsor.

Thanks, 
 Anton

Here are a couple of errors I have spotted at the first glance
- BuildRoot is wrong, please see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473
- you should use "cp -p" or better yet "install -p" in order to preserve the
timestamps of the files
- you should not use "ln -s " in order to install the start/stop script; instead
you should just install the script in it's final location (/etc/init.d) and
allow the admins to use chkconfig to activate/deactivate it; please also make
sure that it is not enabled by default. Given the current shape of the
"profugus" file, it looks like it needs a couple of lines to make it chkconfig-aware
- you should include in the package the text of the license used for the program
(GPL) and also include it as %doc in the binary rpm

Please provide direct links to the spec and src.rpm if possible, not the general
link to the project page.

I fixed my spec file and I have a question regarding chkconfig. Do I need to
include in documentation that in order to run profugus as service they need to
use chkconfig?

Anton

You know what say about documentation, being like sex. If it's good, it is very
good; if it's bad, it's better than nothing. Any decent admin will notice the
presence of the start/stop script, but there would be no harm in pointing it out
in the docs.
Please also make sure to fix the link to Source0, it should respect
http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2

I fixed all problems in spec file:
 - now i use install -p
 - fixed bulidroot
 - fixed daemon script, it now works with chkconfig
 - included %doc
Links:
 SRPM Url:http://downloads.sourceforge.net/profugus/profugus-0.1-3.x86_64.rpm
 Spec URL:http://downloads.sourceforge.net/profugus/profugus.spec

 

Sorry, i put the wrong link for the source. 
Here are new links
SRPM Url: http://downloads.sourceforge.net/profugus/profugus-0.1-3.src.rpm
Spec Url: http://downloads.sourceforge.net/profugus/profugus.spec

Although I don't know well about this package,
from just I checked the spec file on comment 6,
it needs not a few modification.

* Group is incorrect
* Usually the name of the tarball "0.1-3.tar.gz" means
  that the version of spec/srpm should be 0.1.3, not
  0.1
* macro is not used correctly
* config file should be marked in a proper way
* Handling service scripts needs some proper treatment
* %install stage has unneeded procedure
  (check: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets )

I fixed everything except for macro file. Can you please specify what's wrong
with the macro?
Here is my macro:

#
#Macros file for RPM package, created by Anton Kuznetsov
#
#

%packager       Anton Kuznetsov

%distribution   Fedora 6

%vendor         Anton Kuznetsov

%_home          /home/akuznets
%_topdir        /home/akuznets/rpm
%_tmppath       /home/akuznets/rpm/tmp
%_builddir      /home/akuznets/rpm/tmp

%_rpmtopdir     /home/akuznets/rpm/%{name}
%_sourcedir     %{_rpmtopdir}
%_specdir       %{_rpmtopdir}
%_rpmdir        /home/akuznets/rpm/RPMS
%_srcrpmdir     /home/akuznets/rpm/RPMS
%_rpmfilename   %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm

%_signature     gpg
%_gpg_path      /home/akuznets.gnupg
%_gpgbin        /usr/bin/gpg
%_gpg_name      Anton Kuznetsov <akuznets.net>


Thanks,
 Anton

I fixed everything except for macro file. Can you please specify what's wrong
with the macro?
Here is my macro:

#
#Macros file for RPM package, created by Anton Kuznetsov
#
#

%packager       Anton Kuznetsov

%distribution   Fedora 6

%vendor         Anton Kuznetsov

%_home          /home/akuznets
%_topdir        /home/akuznets/rpm
%_tmppath       /home/akuznets/rpm/tmp
%_builddir      /home/akuznets/rpm/tmp

%_rpmtopdir     /home/akuznets/rpm/%{name}
%_sourcedir     %{_rpmtopdir}
%_specdir       %{_rpmtopdir}
%_rpmdir        /home/akuznets/rpm/RPMS
%_srcrpmdir     /home/akuznets/rpm/RPMS
%_rpmfilename   %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm

%_signature     gpg
%_gpg_path      /home/akuznets.gnupg
%_gpgbin        /usr/bin/gpg
%_gpg_name      Anton Kuznetsov <akuznets.net>


Thanks,
 Anton

As I understand nobody really wants to help me out and my project stuck as many
others. Well, anyway i'm gonna continue developing it... just for fun

Here are links of new release:
SRPM Url : http://downloads.sourceforge.net/profugus/profugus-0.2-2.src.rpm
Spec Url :http://downloads.sourceforge.net/profugus/profugus-0.2-2.spec

Umm.. while I can review this, the trouble for me is that
I don't understand Xen *completely*.

Is this program surely working for you? Perhaps I cannot understand
how to use this immediately.

it works for me, but you know that it's better to test it on different systems
if you have any question fell free to ask, also i can send steps how i test
that, so if you have 2 systems with xen installed i can provide information how
to test it.

Actually I have only one machine :) However now I can trust you.

By the first glance at 0.2-2:
For packaging of 0.2-2, some issues must be fixed.

* Version
  - On rpm packaging, "0.2-2" is considered as Version (as hyphen is
    not allowed for rpm version, for this case the rpm version is 0.2.2)
    So the EVR (Epoch:Version:Release) is
    0.2.2-<number>%{?dist}.
* Descriptsion
  - contains too long line (must not exceed 79 characters)
* Arch
  - This package contains only text files and architecture must be
    noarch.
* Macros
  - Please use macros (please check %_sysconfdir, %_mandir,
    %_initrddir for example)
* scripts
---------------------------------------------------
mkdir -p %{buildroot}/etc/rc.d/rc3.d %{buildroot}/etc/rc.d/rc5.d/
---------------------------------------------------
  - Why is this needed?
* Permission
  - The permissions of the following files are incorrect.
-----------------------------------------------------
E: profugus script-without-shebang /etc/profugus.conf
W: profugus spurious-executable-perm /usr/share/man/man8/profugus.8.gz
-----------------------------------------------------
* File entry
  - /etc/profugus.conf is listed twice.
* Requires
  - Add proper %Requires(post), etc (check: "Services" subsection of
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets )
* defattr
  Now we recommend: %defattr(-,root,root,-)

Anton: ping ?

64 bytes from anton : icmp_seq=1 ttl=64 time=0.070 ms
64 bytes from anton : icmp_seq=2 ttl=64 time=0.038 ms

:)

Do you have an fixed srpm to propose about Mamoru comment ?

ZI fixed almost everything. I'm going to upload it in 1 or 2 days.
I had a busy week at work, that's why it took this long to fix it :)

New links:
SRPM URL : http://downloads.sourceforge.net/profugus/profugus-0.2.2-2.src.rpm
Spec URL : http://downloads.sourceforge.net/profugus/profugus-0.2.2-2.spec
Noarch URL: http://downloads.sourceforge.net/profugus/profugus-0.2.2-2.noarch.rpm
x86_64 URL: http://downloads.sourceforge.net/profugus/profugus-0.2.2-2.x86_64.rpm

Well, please check;
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
for general packaging points.

For 0.2.2-2:

* Source0 cannot be found.
* BuildArch is not noarch yet.
* Please use macros: please check:
  http://fedoraproject.org/wiki/Packaging/RPMMacros
* Usually configuration files under %_sysconfdir should
  marked as %config(noreplace)
* Fix up the permission of the files.
  (check "-m" option of install), and don't call chmod
  on %post

ping?

i'm still alive :)
i haven't fixed everything yet. I have really hard time at work and next 2 weeks
will be like hell for me. After that time i should be able to fix everything and
make serious changes to the code

Hi Mamoru, 
 finally i fixed almost everything and uploaded it to sourceforge
SRPM URL : http://downloads.sourceforge.net/profugus/profugus-0.2.3-2.src.rpm
Spec URL : http://downloads.sourceforge.net/profugus/profugus.spec
Noarch URL: http://downloads.sourceforge.net/profugus/profugus-0.2.3-2.noarch.rpm
x86_64 URL: http://downloads.sourceforge.net/profugus/profugus-0.2.3-2.x86_64.rpm

I'm confused by your statement "BuildArch is not noarch yet" In your previous
comment you mention that i need to create noarch package, that i created.
Probably i misunderstand something. Can please clarify?

Thanks,
 Anton

(In reply to comment #22)

> I'm confused by your statement "BuildArch is not noarch yet" In your previous
> comment you mention that i need to create noarch package, that i created.
> Probably i misunderstand something. Can please clarify?
  - You have to specify in your spec file explicitly that this
    package is noarch. i.e. Write:
-----------------------------------------------------------
BuildArch:	noarch
-----------------------------------------------------------
    like:
    http://cvs.fedora.redhat.com/viewcvs/*checkout*/devel/comix/comix.spec

Also:
* Macros
  - Well, please use macros. Check:
    http://fedoraproject.org/wiki/Packaging/RPMMacros
    For example, replace /etc/rc.d/init.d with %{__initrddir}

* License tag
  - License tag policy is now changed. Please change license
    tag according to
    http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
    http://fedoraproject.org/wiki/Licensing

* service status
  - Would you check what "service profugusd status" returns?
    ( I don't have Xen machine ).

ping again?

Hi Mamoru, 
 Sorry, but I dont have time to work on this project because i'm really busy at
work. I think, it's time to close this project. I'm gonna give this project to
some students in a college. Not sure if they want to continue developing this
software.  Anyway it's their choice and you can close this "bug".
Thanks for your help and time

Regards,
 Anton

Okay. Free free to submit a new review request when you want.
Thanks!!