Bug 236491
Summary: | Review Request: ruby-romkan - Romaji <-> Kana conversion library for Ruby | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
Component: | Package Review | Assignee: | Chitlesh GOORAH <chitlesh> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | chitlesh:
fedora-review+
wtogami: fedora-cvs+ |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-04-17 01:12:15 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 236493 |
Description
Mamoru TASAKA
2007-04-15 09:13:50 UTC
The package looks good. I'll take the reviewer. However rpmlint spits: chitlesh(SPECS) [2]$rpmlint /home/chitlesh/rpmbuild/SRPMS/ruby-romkan-0.4-1.src.rpm W: ruby-romkan strange-permission ruby-romkan.spec 0600 W: ruby-romkan strange-permission ruby-romkan-0.4.tar.gz 0600 W: ruby-romkan mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 1) MUST Items: - MUST: The package is named according to the Package Naming Guidelines. - MUST: The package meets the Packaging Guidelines. - MUST: The package is licensed (GPL) with an open-source compatible license and meet other legal requirements as defined in the legal section of Packaging Guidelines. - MUST: The License field in the package spec file matches the actual license Ruby(GPL). - MUST: The spec file is written in American English. - MUST: The sources used to build the package must matches the upstream source, as provided in the spec URL. - MUST: The package successfully compiles and builds into binary rpms on at least i386. - MUST: All build dependencies is listed in BuildRequires. - MUST: the package is not designed to be relocatable - MUST: the package owns all directories that it creates. - MUST: the package does not contain any duplicate files in the %files listing. - MUST: Permissions on files are set properly. - MUST: The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). - MUST: The package consistently uses macros, as described in the macros section of Packaging Guidelines. - MUST: The package contains code, or permissable content. This is described in detail in the code vs. content section of Packaging Guidelines. - MUST: There are no Large documentation files - MUST: %doc does not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. - MUST: The package does not contain library files with a suffix - MUST: Package does not own files or directories already owned by other packages. SHOULD Items: - SHOULD: mock builds succcessfully in i386. - SHOULD: The reviewer tested that the package functions as described. A package should not segfault instead of running, for example. - SHOULD: No scriptlets were used, those scriptlets must be sane. - SHOULD: No subpackages present. APPROVED! Please fix the rpmlint issues as said in Comment #2. Thank you! (In reply to comment #1) > However rpmlint spits: > chitlesh(SPECS) > [2]$rpmlint /home/chitlesh/rpmbuild/SRPMS/ruby-romkan-0.4-1.src.rpm > W: ruby-romkan strange-permission ruby-romkan.spec 0600 > W: ruby-romkan strange-permission ruby-romkan-0.4.tar.gz 0600 > W: ruby-romkan mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 1) Ah.. I uploaded the spec/srpm at the time I didn't fix these... http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/ruby-romkan.spec http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/ruby-romkan-0.4-2.fc7.src.rpm Request for CVS admin: -------------------------------------------------------------- New Package CVS Request ======================= Package Name: ruby-romkan Short Description: Romaji <-> Kana conversion library for Ruby Owners: mtasaka.u-tokyo.ac.jp Branches: devel FC-6 FC-5 InitialCC: (nobody) --------------------------------------------------------------- Rebuilt for all branches, closing. Thank you for reviewing and approving this package!! P.S. I would appreciate it if you would review the last one, migemo itself (bug 236493). |