Bug 2365652

Summary: python-invoke fails to build with Python 3.14: SystemError: buffer overflow in 16 tests
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: python-invokeAssignee: Jiri Kucera <jkucera>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fti-bugs, jkucera, ksurma, mhroncok
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-invoke-2.2.0-9.fc43 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-06-23 12:17:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2322407, 2339432, 2339435, 2371679, 2371899, 2371904    

Description Karolina Surma 2025-05-12 15:02:36 UTC
python-invoke fails to build with Python 3.14.0b1.

16 tests fail with SystemError: buffer overflow

_____________ Local_.pty.when_pty_True_we_use_pty_fork_and_os_exec _____________

self = <runners.Local_.pty object at 0x7fd4da49bc50>

    @mock_pty()
    def when_pty_True_we_use_pty_fork_and_os_exec(self):
        "when pty=True, we use pty.fork and os.exec*"
>       self._run(_, pty=True)

tests/runners.py:1551: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
tests/runners.py:1533: in _run
    return _run(*args, **dict(kwargs, klass=_FastLocal))
tests/runners.py:65: in _run
    return klass(context).run(*args, **kwargs)
../BUILDROOT/usr/lib/python3.14/site-packages/invoke/runners.py:395: in run
    return self._run_body(command, **kwargs)
../BUILDROOT/usr/lib/python3.14/site-packages/invoke/runners.py:440: in _run_body
    self.start(command, self.opts["shell"], self.env)
../BUILDROOT/usr/lib/python3.14/site-packages/invoke/runners.py:1313: in start
    cols, rows = pty_size()
../BUILDROOT/usr/lib/python3.14/site-packages/invoke/terminals.py:125: in pty_size
    cols, rows = _pty_size()
../BUILDROOT/usr/lib/python3.14/site-packages/invoke/terminals.py:96: in _pty_size
    result = fcntl.ioctl(sys.stdout, termios.TIOCGWINSZ, buf)
/usr/lib64/python3.14/unittest/mock.py:1170: in __call__
    return self._mock_call(*args, **kwargs)
/usr/lib64/python3.14/unittest/mock.py:1174: in _mock_call
    return self._execute_mock_call(*args, **kwargs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <MagicMock name='ioctl' id='140552170361520'>
args = (<_io.TextIOWrapper name='<stdout>' mode='w' encoding='utf-8'>, 21523, b'\x00\x00\x00\x00')
kwargs = {}, effect = None

    def _execute_mock_call(self, /, *args, **kwargs):
        # separate from _increment_mock_call so that awaited functions are
        # executed separately from their call, also AsyncMock overrides this method
    
        effect = self.side_effect
        if effect is not None:
            if _is_exception(effect):
                raise effect
            elif not _callable(effect):
                result = next(effect)
                if _is_exception(result):
                    raise result
            else:
                result = effect(*args, **kwargs)
    
            if result is not DEFAULT:
                return result
    
        if self._mock_return_value is not DEFAULT:
            return self.return_value
    
        if self._mock_delegate and self._mock_delegate.return_value is not DEFAULT:
            return self.return_value
    
        if self._mock_wraps is not None:
>           return self._mock_wraps(*args, **kwargs)
E           SystemError: buffer overflow

/usr/lib64/python3.14/unittest/mock.py:1247: SystemError

https://docs.python.org/3.14/whatsnew/3.14.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.14-b1/fedora-rawhide-x86_64/09022793-python-invoke/

For all our attempts to build python-invoke with Python 3.14, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.14-b1/package/python-invoke/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.14:
https://copr.fedorainfracloud.org/coprs/g/python/python3.14-b1/

Let us know here if you have any questions.

Python 3.14 is planned to be included in Fedora 43.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.14.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karolina Surma 2025-06-11 16:00:02 UTC
*** Bug 2371949 has been marked as a duplicate of this bug. ***

Comment 2 Fedora Fails To Install 2025-06-20 19:52:30 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 3 Dominik 'Rathann' Mierzejewski 2025-06-21 17:20:56 UTC
I think this was reported upstream, too.

Comment 4 Dominik 'Rathann' Mierzejewski 2025-06-21 17:30:51 UTC
PR submitted upstream and downstream: https://src.fedoraproject.org/rpms/python-invoke/pull-request/5 .

Comment 5 Fedora Update System 2025-06-23 12:09:41 UTC
FEDORA-2025-d6cb3345d9 (python-invoke-2.2.0-9.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d6cb3345d9

Comment 6 Fedora Update System 2025-06-23 12:17:03 UTC
FEDORA-2025-d6cb3345d9 (python-invoke-2.2.0-9.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Jiri Kucera 2025-06-30 07:54:22 UTC
Clearing needinfo since the issue is already fixed.