Bug 2366666

Summary: Far too much padding in storage editor main display
Product: [Fedora] Fedora Reporter: Adam Williamson <awilliam>
Component: cockpitAssignee: Freya Gustavsson <fgustavs>
Status: MODIFIED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: jkonecny, jvanderwaa, kkoukiou, mkolman, mmarusak, mpitt, patrick, rvykydal, stefw
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
the old storage editor UI, showing four things at once
none
the new storage editor UI, only managing to show three things at once none

Description Adam Williamson 2025-05-15 19:59:58 UTC 
The anaconda-webui storage editor main page with the new patternfly/cockpit has waay too much padding. At 1024z768 it can't display more than three things at the same time. This makes the openQA test fail because it can't see "unformatted space" any more. I can work around that by having the test scroll, but this much padding is just unnecessary and looks ugly.

Attaching screenshots of the previous UI showing three devices plus unformatted space, and the new UI stuck with just two.
Comment 1 Adam Williamson 2025-05-15 20:00:43 UTC 
Created attachment 2090006 [details]
the old storage editor UI, showing four things at once
Comment 2 Adam Williamson 2025-05-15 20:01:09 UTC 
Created attachment 2090007 [details]
the new storage editor UI, only managing to show three things at once
Comment 3 Freya Gustavsson 2025-05-16 10:15:43 UTC 
With Cockpit's upgrade to Patternfly v6 UI it seems like we added a override that was too much. Katerina found the root cause at
https://github.com/cockpit-project/cockpit/blob/a70142a7a6f9c4e78e71f3c4ec738b6db2fbb04f/pkg/lib/patternfly/patternfly-6-overrides.scss#L357

I'll investigate and improve the styling. I can't promise we'll fit more than 3 items but it will at least reduce in size. I don't want too many overrides if we can avoid it. I'll keep you posted