Bug 2367781

Summary: Review Request: perl-Mail-DMARC - Perl implementation of DMARC
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: jplesnik: fedora-review+
Hardware: All   
OS: Linux   
URL: https://metacpan.org/dist/Mail-DMARC
Whiteboard:
Fixed In Version: perl-Mail-DMARC-1.20250203-1.fc43 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-05-27 08:12:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2025-05-21 12:59:37 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Mail-DMARC/perl-Mail-DMARC.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Mail-DMARC/perl-Mail-DMARC-1.20250203-1.fc43.src.rpm
Description:
This module is a suite of tools for implementing DMARC. It adheres to the
2013 DMARC draft.

Fedora Account System Username: ppisar

Comment 1 Fedora Review Service 2025-05-21 13:43:37 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9069715
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2367781-perl-mail-dmarc/fedora-rawhide-x86_64/09069715-perl-Mail-DMARC/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Jitka Plesnikova 2025-05-26 15:57:34 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok

All tests passed

BuildRequires are ok

Binary requires are Ok.

Binary provides are Ok.

$ rpmlint ./perl-Mail-DMARC*
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml 
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 6

perl-Mail-DMARC.src: W: strange-permission repackage.sh 775
perl-Mail-DMARC-HTTP.noarch: E: spelling-error ('httpd', '%description -l en_US httpd -> HTTP') 
perl-Mail-DMARC-HTTP.noarch: E: spelling-error ('jqgrid', '%description -l en_US jqgrid -> grid')
perl-Mail-DMARC-Test.noarch: W: no-documentation
perl-Mail-DMARC-tests.noarch: W: no-documentation
perl-Mail-DMARC.spec: W: invalid-url Source0: Mail-DMARC-1.20250203_repackaged.tar.gz
perl-Mail-DMARC.spec: W: invalid-url Source0: Mail-DMARC-1.20250203_repackaged.tar.gz
perl-Mail-DMARC-tests.noarch: W: dangling-relative-symlink /usr/libexec/perl-Mail-DMARC/share ../../share/perl5/vendor_perl/auto/share/dist/Mail-DMARC
 5 packages and 1 specfiles checked; 2 errors, 6 warnings, 22 filtered, 2 badness; has taken 1.1 s
Rpmlint is ok
- Source0 is repackaged for original source


The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 4 Fedora Admin user for bugzilla script actions 2025-05-27 07:10:02 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Mail-DMARC

Comment 5 Petr Pisar 2025-05-27 07:52:01 UTC
Thank you for the review.