Bug 2367909

Summary: tomcli FTBFS with click 8.2.1 and also makes other packages FTBFS
Product: [Fedora] Fedora Reporter: Charalampos Stratakis <cstratak>
Component: tomcliAssignee: Maxwell G <maxwell>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: maxwell
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-06-06 18:55:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2365473    

Description Charalampos Stratakis 2025-05-22 01:07:31 UTC
Testing the latest click 8.2.1 update and tomcli FTBFS with:

Traceback (most recent call last):
  File "/builddir/build/BUILD/tomcli-0.9.0-build/tomcli-0.9.0/compgen.py", line 83, in <module>
    main()
    ~~~~^^
  File "/usr/lib/python3.13/site-packages/click/core.py", line 1442, in __call__
    return self.main(*args, **kwargs)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/click/core.py", line 1363, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3.13/site-packages/click/core.py", line 1226, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/click/core.py", line 794, in invoke
    return callback(*args, **kwargs)
  File "/builddir/build/BUILD/tomcli-0.9.0-build/tomcli-0.9.0/compgen.py", line 73, in main
    out: bytes = subprocess.run(
                 ~~~~~~~~~~~~~~^
        [command],
        ^^^^^^^^^^
    ...<2 lines>...
        capture_output=True,
        ^^^^^^^^^^^^^^^^^^^^
    ).stdout
    ^
  File "/usr/lib64/python3.13/subprocess.py", line 577, in run
    raise CalledProcessError(retcode, process.args,
                             output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['tomcli']' returned non-zero exit status 1.

Copr link: https://copr.fedorainfracloud.org/coprs/cstratak/click-8.2.1/build/9068647/

However other packages FTBFS currently due to that with this error:

Traceback (most recent call last):
  File "/usr/bin/tomcli", line 5, in <module>
    from tomcli.cli.main import APP
  File "/usr/lib/python3.13/site-packages/tomcli/cli/main.py", line 12, in <module>
    from . import get as get_cmd
  File "/usr/lib/python3.13/site-packages/tomcli/cli/get.py", line 49, in <module>
    @add_args_and_help(
     ~~~~~~~~~~~~~~~~~^
        SHARED_PARAMS.path,
        ^^^^^^^^^^^^^^^^^^^
        SharedArg(click.argument("selector", default="."), help=SELECTOR_HELP),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/lib/python3.13/site-packages/tomcli/cli/_util.py", line 196, in inner
    metavar = func.__click_params__[-1].make_metavar().removesuffix("...")  # type: ignore[attr-defined]
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
TypeError: Argument.make_metavar() missing 1 required positional argument: 'ctx'

Example Copr link: https://copr.fedorainfracloud.org/coprs/cstratak/click-8.2.1/build/9068591/

Reproducible: Always

Comment 1 Maxwell G 2025-06-06 18:13:43 UTC
I am testing a fix for this upstream. Thanks for the report!

Comment 3 Maxwell G 2025-06-06 18:55:34 UTC
Building tomcli-0.10.0-1.fc43 for f43-python
Created task: 133631417
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=133631417