Bug 2369118

Summary: Review Request: rust-nohash-hasher - Implementation of std::hash::Hasher which does not hash at all
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/nohash-hasher
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-05-30 15:41:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Davide Cavalca 2025-05-29 03:54:12 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-nohash-hasher/rust-nohash-hasher.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-nohash-hasher/rust-nohash-hasher-0.2.0-5.fc43.src.rpm

Description:
An implementation of `std::hash::Hasher` which does not hash at all.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2025-05-29 03:54:14 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=133296994

Comment 2 Davide Cavalca 2025-05-29 03:54:52 UTC
This will need to be unretired: https://src.fedoraproject.org/rpms/rust-nohash-hasher

Previous review: https://bugzilla.redhat.com/show_bug.cgi?id=1990711

Comment 3 Fedora Review Service 2025-05-29 06:26:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9100126
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2369118-rust-nohash-hasher/fedora-rawhide-x86_64/09100126-rust-nohash-hasher/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-nohash-hasher
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Michel Lind 2025-05-29 16:51:56 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
- [BINARY ONLY] licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Davide Cavalca 2025-05-29 17:39:52 UTC
Unretirement ticket: https://pagure.io/releng/issue/12761

Comment 6 Fedora Update System 2025-05-30 15:37:44 UTC
FEDORA-2025-491ee9e0a8 (rust-nohash-hasher-0.2.0-5.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-491ee9e0a8

Comment 7 Fedora Update System 2025-05-30 15:41:01 UTC
FEDORA-2025-491ee9e0a8 (rust-nohash-hasher-0.2.0-5.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2025-05-30 15:55:32 UTC
FEDORA-2025-4e6e7ee384 (rust-nohash-hasher-0.2.0-5.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-4e6e7ee384

Comment 9 Fedora Update System 2025-05-30 16:05:18 UTC
FEDORA-2025-be76268284 (rust-nohash-hasher-0.2.0-5.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-be76268284

Comment 10 Fedora Update System 2025-05-31 00:53:38 UTC
FEDORA-2025-be76268284 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-be76268284 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-be76268284

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2025-05-31 02:28:55 UTC
FEDORA-2025-4e6e7ee384 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-4e6e7ee384 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-4e6e7ee384

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2025-06-07 05:42:46 UTC
FEDORA-2025-be76268284 (rust-nohash-hasher-0.2.0-5.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2025-06-07 06:46:18 UTC
FEDORA-2025-4e6e7ee384 (rust-nohash-hasher-0.2.0-5.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.