Bug 2372909

Overall this looks nice. One minor nit is that in the spec file you have in the %files section:

%license %{gem_instdir}/LICENSE.txt

But I'd prefer:

%exclude %{gem_instdir}/LICENSE.txt
%license LICENSE.txt

The result is that it nicely shows up in /usr/share/licenses/rubygem-track_open_instances/LICENSE.txt instead of /usr/share/gems/gems/track_open_instances-0.1.15/LICENSE.txt.

I'm still setting review to + because that's something that can be fixed later if desired.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License". 20 files have unknown
     license. Detailed output of licensecheck in
     /home/ekohl/dev/fedora/rubygem-track_open_instances/2372909-rubygem-
     track_open_instances/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[-]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: When checking ruby code, install the ruby plugin.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rubygem-track_open_instances-0.1.15-1.fc43.noarch.rpm
          rubygem-track_open_instances-doc-0.1.15-1.fc43.noarch.rpm
          rubygem-track_open_instances-0.1.15-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.6.1
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmperxk8htm')]
checks: 32, packages: 3

rubygem-track_open_instances.noarch: W: no-documentation
rubygem-track_open_instances-doc.noarch: W: hidden-file-or-dir /usr/share/gems/gems/track_open_instances-0.1.15/.release-please-manifest.json
 3 packages and 0 specfiles checked; 0 errors, 2 warnings, 12 filtered, 0 badness; has taken 0.2 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 2

rubygem-track_open_instances.noarch: W: no-documentation
rubygem-track_open_instances-doc.noarch: W: hidden-file-or-dir /usr/share/gems/gems/track_open_instances-0.1.15/.release-please-manifest.json
 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 8 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://github.com/main-branch/track_open_instances/archive/v0.1.15/track_open_instances-0.1.15.tar.gz :
  CHECKSUM(SHA256) this package     : 09f17263eb3ca6a0bdfcb4dfd6d4d68e5370595872f48b0a1d5388b3484d81de
  CHECKSUM(SHA256) upstream package : 09f17263eb3ca6a0bdfcb4dfd6d4d68e5370595872f48b0a1d5388b3484d81de
https://rubygems.org/gems/track_open_instances-0.1.15.gem :
  CHECKSUM(SHA256) this package     : 7f0e48821e6b4c881daaa40fb1583e308937c22a9c84883c150b399c3b5c3029
  CHECKSUM(SHA256) upstream package : 7f0e48821e6b4c881daaa40fb1583e308937c22a9c84883c150b399c3b5c3029


Requires
--------
rubygem-track_open_instances (rpmlib, GLIBC filtered):
    ruby(rubygems)

rubygem-track_open_instances-doc (rpmlib, GLIBC filtered):
    rubygem-track_open_instances



Provides
--------
rubygem-track_open_instances:
    rubygem(track_open_instances)
    rubygem-track_open_instances

rubygem-track_open_instances-doc:
    rubygem-track_open_instances-doc



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2372909
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: R, Haskell, SugarActivity, Java, Python, C/C++, fonts, Perl, Ocaml, PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Thanks.

/usr/share/licenses/rubygem-track_open_instances/LICENSE.txt

is a much better location indeed - will adjust.

Steve.

The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-track_open_instances

FEDORA-2025-ca899e3f13 (rubygem-track_open_instances-0.1.15-2.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-ca899e3f13

FEDORA-2025-ca899e3f13 (rubygem-track_open_instances-0.1.15-2.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.