Bug 2372951

Summary: Review Request: perl-Crypt-SmbHash - Perl module for generating SMB password hashes (EPEL9)
Product: [Fedora] Fedora EPEL Reporter: Akiyoshi Kurita <akito5623>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel9CC: carl, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://metacpan.org/release/Crypt-SmbHash
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-06-19 17:35:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Akiyoshi Kurita 2025-06-16 05:25:14 UTC
Spec and SRPM are available at:

https://github.com/redadmin-k/perl-Crypt-SmbHash-almalinux9

This Perl module provides SMB hash functions (LAN Manager and NT password hashes) required by smbldap-tools.

This submission is required as a dependency for smbldap-tools, which is under review in Bug #2372674:
https://bugzilla.redhat.com/show_bug.cgi?id=2372674

License: GPL+ or Artistic
Upstream: https://metacpan.org/pod/Crypt::SmbHash

This package is being revived for EPEL9 to restore compatibility with legacy Samba + LDAP environments.
Maintainer: Akiyoshi Kurita (redadmin-k)

Comment 1 Fedora Review Service 2025-06-17 04:48:53 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2025-06-17 05:08:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9168872
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2372951-perl-crypt-smbhash/fedora-rawhide-x86_64/09168872-perl-Crypt-SmbHash/fedora-review/review.txt

Found issues:

- Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) has to be removed
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/
- Not a valid SPDX expression 'GPLv2+'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/perl-Crypt-SmbHash
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Akiyoshi Kurita 2025-06-17 05:45:56 UTC
The spec file and license tag have been updated:

- Updated License to SPDX format: GPL-2.0-or-later
- Removed: Requires: perl(:MODULE_COMPAT_%...)

SRPM URL: https://github.com/redadmin-k/perl-Crypt-SmbHash-almalinux9/releases/download/v0.12-43/perl-Crypt-SmbHash-0.12-42.el9.src.rpm
Spec URL: https://github.com/redadmin-k/perl-Crypt-SmbHash-almalinux9/blob/perl-Crypt-SmbHash/perl-Crypt-SmbHash.spec

[fedora-review-service-build]

Comment 6 Carl George 🤠 2025-06-19 17:35:22 UTC
Package reviews are not the correct way to request Fedora packages be added to EPEL.  You've already been provided instructions for how to do this properly in several other locations.  Please take the time to read those instructions.