Bug 237336
Summary: | Review Request: perl-Crypt-OpenSSL-X509 -- Perl OpenSSL bindings for X509 support | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Wes Hardaker <wjhns174> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | steve.traylen |
Target Milestone: | --- | Flags: | j:
fedora-review+
petersen: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-05-31 23:11:18 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Wes Hardaker
2007-04-20 20:37:14 UTC
Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-X509.spec SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-X509-0.4-1.src.rpm fixed srpm url. Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-X509.spec SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-X509-0.4-2.src.rpm - Add BuildRequire openssl-devel - Don't manually require openssl - Use vendorarch instead of vendorlib Spec URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-X509.spec SRPM URL: http://www.hardakers.net/FE/perl-Crypt-OpenSSL-X509-0.4-3.src.rpm - BuildRequire perl(Test::More) perl(Test::Pod) - Fixed source code URL Not much to say here; everything looks good. The only oddify is this: Checking if your kit is complete... Warning: the following files are missing in your kit: inc inc/Module inc/Module/Install Please inform the author. Except that those are actually there, as directories. I don't think directories are supposed to be listed separately in the manifest but I'm not really certain. Perhaps it's worth passing that on to upstream. * source files match upstream: a10433ff68b70687bac6832d5814db730147d3dc0cbf3e61c08a0711851c879e Crypt-OpenSSL-X509-0.4.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: X509.so()(64bit) perl(Crypt::OpenSSL::X509) = 0.4 perl-Crypt-OpenSSL-X509 = 0.4-3.fc7 = libcrypto.so.6()(64bit) perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(base) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=2, Tests=10, 0 wallclock secs ( 0.07 cusr + 0.03 csys = 0.10 CPU) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la droppings. APPROVED FYI, upstream notified. New Package CVS Request ======================= Package Name: perl-Crypt-OpenSSL-X509 Short Description: Perl OpenSSL bindings for X509 Support Owners: wjhns174 Branches: FC-6 F-7 InitialCC: CVS done. It may take a bit before Koji is syncronized. Package Change Request ====================== Package Name: perl-Crypt-OpenSSL-X509 New Branches: EL-4 EL-5 Owners: stevetraylen InitialCC: perl-sig I contacted the package owner over a week requesting the addition of perl-Crypt-OpenSSL-X509 to EPEL without response. I would now like to maintain this within EPEL. Steve I've been swamped for the last week, sorry... I'd be fine with you taking on the development for EPEL if you like though. This looks like it went into EPEL some time ago ex Fedora /mnt/nfs/var/ftp/pub/mirror/redhat/rhel/epel/pub/fedora/linux/development/source/SRPMS/perl-Crypt-OpenSSL-X509-0.4-3.fc8.src.rpm [herrold@centos-5 perl-Crypt-OpenSSL-X509]$ perl-rpmbuild --rebuild perl-Crypt-OpenSSL-X509-0.4-3.fc8.src.rpm warning: user kojibuilder does not exist - using root warning: group kojibuilder does not exist - using root warning: user kojibuilder does not exist - using root warning: group kojibuilder does not exist - using root [herrold@centos-5 perl-Crypt-OpenSSL-X509]$ still builds on centos 5 what is the issue? was it orphaned out/ There are simply no build directories for it. We need something like this done: New Package CVS Request ======================= Package Name: perl-Crypt-OpenSSL-X509 Short Description: Perl OpenSSL bindings for X509 Support Owners: wjhns174 Branches: EL-4 EL-5 InitialCC: I think we need a new bug request for it; sigh... my memory of fedora create-a-new-branch methodology fails me after not having done it for a year (as always). Don't really understand the history here , for me today its certainly not in EPEL. If you can maintain in EPEL that would be great. I think you want a Package change request rather than new. In fact exactly the same as what I have in Comment #8 with your user name. To avoid confusion I will switch the fedora-cvs flag on this bug back to +. Once you have package change request in then change it to ? for them to process. Thanks again for offering to maintain in EPEL. Very useful. Steve Hi Wes, Can you make the package request and maintain the package? Else I will :-) Steve Package Change Request ====================== Package Name: perl-Crypt-OpenSSL-X509 New Branches: EL-4 EL-5 Owners: wjhns174 steve.traylen FYI according to the docs the flag needed to be set to ? not + to get it to show up in their queue. Also note that Owners needs to have Fedora account names, not email addresses. Could you submit a corrected request? Package Change Request ====================== Package Name: perl-Crypt-OpenSSL-X509 New Branches: EL-4 EL-5 Owners: hardaker CVS done. Package Change Request ====================== Package Name: perl-Crypt-OpenSSL-X509 New Branches: epel7 Owners: hardaker Need to port this package to el7 Git done (by process-git-requests). no perl-sig CC? |