Bug 237662
| Summary: | CUPS D-Bus notifier | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tim Waugh <twaugh> | ||||||||||
| Component: | cups | Assignee: | Tim Waugh <twaugh> | ||||||||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||||||||
| Severity: | medium | Docs Contact: | |||||||||||
| Priority: | medium | ||||||||||||
| Version: | 10 | CC: | bjohnson, tiagomatos, tuju | ||||||||||
| Target Milestone: | --- | ||||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2009-05-14 15:26:02 UTC | Type: | --- | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Tim Waugh
2007-04-24 15:50:43 UTC
Removing: JobStateChanged This is not a real event, but a convenience mask. STRING printer-state-reasons This is a comma-separated list. For the Printer* and Job* signals: STRING printer-uri May be "" if there is no associated printer, in which case the other printer parameters must be ignored. STRING printer-name INT32 printer-state STRING printer-state-reasons This is a comma separated list. BOOL printer-is-accepting-jobs Rationale: printer-uri may not be supplied in a job signal if the job never started. Created attachment 153536 [details]
cups-dbus-notifier.patch
Here's what I have so far. It seems to work, but printer-is-accepting-jobs
always seems to be false which doesn't seem right.
PrinterStateChanged has been removed for the same reasons as JobStateChanged. New parameter inserted before all the others: STRING text. This comes from notify-text, and applies to all signals. PrinterConfigChanged and PrinterChanged removed as well, since they are also bitmasks. Created attachment 153613 [details]
cups-dbus-notifier.patch
Okay, this patch seems to work quite well now.
Created attachment 153707 [details]
cups-dbus-notifier.patch
Here is an updated patch.
PrinterStateChanged is added back in because cupsd does emit this notification
('printer-state-changed'). Should JobStateChanged be added back in, even
though it is a convenience bitmask and cupsd does not emit that notification?
A lock-file is now used to prevent duplicate D-BUS message when more than one
dbus: subscription is in place.
Created attachment 154538 [details]
cups-dbus-notifier.patch
Added license banner to dbus.c.
Changing version to '9' as part of upcoming Fedora 9 GA. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Deferring to rawhide. This bug appears to have been reported against 'rawhide' during the Fedora 10 development cycle. Changing version to '10'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping CUPS 1.4 (in rawhide) has a D-Bus notifier now. Keeping open for F-10 in case of backport. No time for this. |