Bug 237667
| Summary: | network-bridge fails on some machines | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Daniel de Kok <danieldk> | ||||
| Component: | xen | Assignee: | Herbert Xu <herbert.xu> | ||||
| Status: | CLOSED ERRATA | QA Contact: | |||||
| Severity: | high | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5.0 | CC: | xen-maint | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | RHEA-2007-0635 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-11-07 17:10:23 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 236524 | ||||||
| Attachments: |
|
||||||
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Created attachment 153392 [details]
Fix addr_pfx test
Actually, we do want to keep the 'scope global' when copying the address. I
think the problem here is that the addr_pfx shell test doesn't cope with the
space. Could you please see if this patch makes your problem go away?
Thanks.
Confirmed, the patch fixes this problem correctly. Thanks! Built as xen-3.0.3-30.el5 into dist-5E-qu-candidate * Tue Jun 26 2007 Daniel P. Berrange <berrange> - 3.0.3-30.el5 - Fix address test in network-bridge (rhbz 237667) An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHEA-2007-0635.html |
Description of problem: network-bridge fails halfway the script, leaving networking in a unusable state, due to incorrect parsing of 'ip addr show' output. Version-Release number of selected component (if applicable): xen-3.0.3-25.0.3.el5 How reproducible: Upgrade to this package version. Additional info: xen-network-bonding-fix.patch makes the following change: --- get_ip_info() { - addr_pfx=`ip addr show dev $1 | egrep '^ *inet' | sed -e 's/ *inet //' -e 's/ .*//'` + addr_pfx=`ip addr show dev $1 | sed -n 's/^ *inet \(.*\) [^ ]*$/\1/p'` gateway=`ip route show dev $1 | fgrep default | sed 's/default via //'` } --- This doesn't work for all 'ip addr show' output, for instance: --- # ip addr show dev eth1 8: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue link/ether 00:30:6e:12:d3:5a brd ff:ff:ff:ff:ff:ff inet 192.168.1.17/24 scope global eth1 inet6 fe80::230:6eff:fe12:d35a/64 scope link valid_lft forever preferred_lft forever --- Reverting back to the old line fixes this problem. Though this is not to accurate either, because it also includes inet6 lines. This works great for me: --- addr_pfx=`ip addr show dev $1 | egrep '^ *inet ' | sed -e 's/ *inet //' -e 's/ .*//'` ---