Bug 2377098 (rust-rstest0.24)

Summary:	Review Request: rust-rstest0.24 - Rust fixture based test framework
Product:	[Fedora] Fedora	Reporter:	Marc-Andre Lureau <marcandre.lureau>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WORKSFORME	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2025-07-30 14:41:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2377085
Bug Blocks:	2377151

Description Marc-Andre Lureau 2025-07-08 09:46:34 UTC

Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-rstest0.24/rust-rstest0.24.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/09248604/rust-rstest0.24-0.24.0-1.src.rpm

Description: 
Rust fixture based test framework. It use procedural macro to implement
fixtures and table based tests.

Fedora Account System Username: elmarco

- 0.24 is required by newer 0.25 for testing
- Testing is disabled for this version, because there is an issue with the crate: "error[E0432]: unresolved import `rstest_test`". I didn't investigate further.

Comment 1 Cristian Le 2025-07-21 13:05:07 UTC

Is there more context about this review request? Which package is this one needed for, and can that dependency not be relaxed?

Comment 2 Marc-Andre Lureau 2025-07-21 17:30:40 UTC

As explained above, 0.24 is required by 0.25. But we drop the tests anyway at the moment. So we could drop this too.

Comment 3 Cristian Le 2025-07-21 18:08:24 UTC

> As explained above, 0.24 is required by 0.25

I don't see where that is the case. Can you link me the upstream reference in upstream? The only reference I could find is in `rstest_test` which is not packaged in Fedora.

But still the question remains, and applies for 0.25 as well:

> Which package is this one needed for, and can that dependency not be relaxed?

The depends-on that you've linked up to `rust-picky` has a trivial patch when they bumped the version [1], so you can just relax that dependency. Then you don't need the compat package and it will just be handled behind-the-scenes when the other dependencies of `rust-rstest` can be ported.

Also, compat packages should be made for the older versions, not newer one, in order to at least retain a git history.

[1]: https://github.com/Devolutions/picky-rs/commit/5a2df5cc545656ddf86db59337048b99216160ac

Comment 4 Marc-Andre Lureau 2025-07-21 18:24:39 UTC

https://src.fedoraproject.org/rpms/rust-rstest/blob/rawhide/f/rust2rpm.toml#_3

I figured this after, so we can drop this review request.

"compat packages should be made for the older versions", I asked this on Fedora Rust. I didn't get an answer. Imho, it would be simpler to have compat package by default for some rust crates that break version regularly, like this one.